Skip to content

[Refactor] 경기 일정에서 LCK 이외의 팀도 대응 #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JinUng41 merged 2 commits into from
Jul 8, 2025
Merged

[Refactor] 경기 일정에서 LCK 이외의 팀도 대응 #263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b56981
[Refactor] #262 - 경기 일정에서 LCK 이외의 팀도 대응하도록 수정
JinUng41 Jul 7, 2025
f91ca6e
[Chore] #262 - 배열 사용하도록 수정
JinUng41 Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Wable-iOS/Data/Mapper/InformationMapper.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ enum InformationMapper {
let games = dto.games.compactMap { gameDTO in
Game(
date: gameDateFormatter.date(from: gameDTO.gameDate),
homeTeam: LCKTeam(rawValue: gameDTO.aTeamName),
homeTeam: gameDTO.aTeamName,
homeScore: gameDTO.aTeamScore,
awayTeam: LCKTeam(rawValue: gameDTO.bTeamName),
awayTeam: gameDTO.bTeamName,
awayScore: gameDTO.bTeamScore,
status: GameStatus(rawValue: gameDTO.gameStatus.uppercased())
)
Expand Down
4 changes: 2 additions & 2 deletions Wable-iOS/Domain/Entity/GameSchedule.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@ struct GameSchedule: Hashable {

struct Game: Hashable {
let date: Date?
let homeTeam: LCKTeam?
let homeTeam: String
let homeScore: Int
let awayTeam: LCKTeam?
let awayTeam: String
let awayScore: Int
let status: GameStatus?
}
6 changes: 3 additions & 3 deletions Wable-iOS/Domain/UseCase/Overview/OverviewUseCase.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,9 +112,9 @@ struct MockOverviewUseCaseImpl: OverviewUseCase {

let game = Game(
date: date,
homeTeam: lckTeams[homeTeamIndex],
homeTeam: lckTeams[homeTeamIndex].rawValue,
homeScore: index * 2 + 1,
awayTeam: lckTeams[awayTeamIndex],
awayTeam: lckTeams[awayTeamIndex].rawValue,
awayScore: index * 2 + 2,
status: .scheduled
)
Expand All @@ -124,7 +124,7 @@ struct MockOverviewUseCaseImpl: OverviewUseCase {
mockGameSchedules.append(GameSchedule(date: date, games: games))
}

return .just([])
return .just(mockGameSchedules)
}

private func createMockTeamRanks() -> AnyPublisher<[LCKTeamRank], WableError> {
Expand Down
8 changes: 4 additions & 4 deletions Wable-iOS/Presentation/Overview/GameSchedule/View/GameScheduleListViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,11 +134,11 @@ private extension GameScheduleListViewController {
let gameStatus = game.status ?? .progress
let gameTimeText = gameTimeFormatter.string(from: game.date ?? Date())

let homeTeamName = game.homeTeam?.rawValue ?? "TBD"
let homeTeamLogoImage = UIImage(named: homeTeamName.lowercased())
let homeTeamName = game.homeTeam
let homeTeamLogoImage = UIImage(named: homeTeamName.lowercased()) ?? .tbd

let awayTeamName = game.awayTeam?.rawValue ?? "TBD"
let awayTeamLogoImage = UIImage(named: awayTeamName.lowercased())
let awayTeamName = game.awayTeam
let awayTeamLogoImage = UIImage(named: awayTeamName.lowercased()) ?? .tbd

cell.configure(
gameStatusImage: gameStatus.image,
Expand Down