-
Notifications
You must be signed in to change notification settings - Fork 0
[Fix] 프로필 기능 개선 및 기타 오류 수정 #197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
c97ffc5
[Fix] #196 - 프로그레스바 적용 값 수정
JinUng41 2b458d4
[Fix] #196 - 프로필 인포 터치 시 글 상세페이지로 이동하는 것 막기
JinUng41 20fbfc1
[Fix] #196 - 네비게이션 팝 제스처 코드 수정
JinUng41 11980d4
[Fix] #196 - 뷰잇 밴 후 다시 리스트 받도록 수정
JinUng41 6cb598c
[Feat] #196 - 뷰잇 프로필 이동 추가
JinUng41 4ce2bcc
[Chore] #196 - 폴더링
JinUng41 c1afc3c
[Feat] #196 - 마이페이지 글, 댓글 삭제 기능 구현
JinUng41 8fbe787
[Fix] #196 - 댓글 셀이 보이지 않는 문제 해결
JinUng41 95d6c28
[Chore] #196 - 오타 수정
JinUng41 8c370ce
[Feat] #196 - 마이페이지 글, 댓글 좋아요 구현
JinUng41 d94340a
[Chore] #196 - 메서드명 수정
JinUng41 303a6bf
[Refactor] #196 - 프로필 컴바인 기반 코드 수정
JinUng41 3adbe3d
[Chore] #196 - 지역 변수명 변경
JinUng41 38c8e3e
[Feat] #196 - 다른 사람 프로필 좋아요 구현
JinUng41 4bc19ff
[Feat] #196 - 상대방 프로필 신고하기, 밴하기 기능 추가
JinUng41 17a9779
[Feat] #196 - 다른 사람 프로필 투명도 내리기 기능 구현
JinUng41 9b6c843
[Fix] #196 - 뷰잇 신고 후, 동작 수정
JinUng41 1ddc361
[Fix] #196 - 프로필 레벨 배지 이미지 적용
JinUng41 2f7d261
[Chore] #196 - 사용하지 않는 코드 삭제
JinUng41 98b555c
[Chore] #196 - 코드 다듬기
JinUng41 6b1a4f0
[Refactor] #196 - 모델명 변경
JinUng41 c0b012b
[Chore] #196 - 잘못된 개행 수정
JinUng41 93b412c
[Style] #196 - 이미지 표현 방식 수정
JinUng41 a949f3e
[Add] #196 - 레벨 뱃지 이미지 추가
youz2me 817022e
Merge branch 'fix/#196-profile-improvements' of https://github.com/Te…
JinUng41 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -55,7 +55,7 @@ final class AnnouncementDetailViewController: UIViewController { | |
| super.viewDidLoad() | ||
|
|
||
| setupAction() | ||
| setupDelegate() | ||
| setupNavigationBar() | ||
| } | ||
|
|
||
| func configure( | ||
|
|
@@ -83,14 +83,6 @@ final class AnnouncementDetailViewController: UIViewController { | |
| } | ||
| } | ||
|
|
||
| // MARK: - UIGestureRecognizerDelegate | ||
|
|
||
| extension AnnouncementDetailViewController: UIGestureRecognizerDelegate { | ||
| func gestureRecognizerShouldBegin(_ gestureRecognizer: UIGestureRecognizer) -> Bool { | ||
| return navigationController?.viewControllers.count ?? 0 > 1 | ||
| } | ||
| } | ||
|
|
||
| // MARK: - Setup Method | ||
|
|
||
| private extension AnnouncementDetailViewController { | ||
|
|
@@ -103,8 +95,9 @@ private extension AnnouncementDetailViewController { | |
| submitButton.addTarget(self, action: #selector(submitButtonDidTap), for: .touchUpInside) | ||
| } | ||
|
|
||
| func setupDelegate() { | ||
| navigationController?.interactivePopGestureRecognizer?.delegate = self | ||
| func setupNavigationBar() { | ||
| navigationController?.navigationBar.isHidden = true | ||
| navigationController?.interactivePopGestureRecognizer?.isEnabled = true | ||
|
Comment on lines
-106
to
+100
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
| } | ||
| } | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
헉
SS로 하지 않아도 상관 없나요? 뭔가 항상 대문자와 소문자를 교차로 사용했던 것 같은데 아니어도 괜찮은거였나 보군요 ,,,There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
제가 알기로는
SS는 잘못된 표현 방식으로 알고 있습니다.대문자로 표기되는 것들은 그 만의 형식?(24시간/12시간)이 있어서 사용하는 것으로 알고 있어요.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
그랬군요 🫨 모르고 살뻔 했네요 ,,, 감사합니닷.