-
Notifications
You must be signed in to change notification settings - Fork 0
[Fix] 1차 QA 반영 #176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[Fix] 1차 QA 반영 #176
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
3b55215
[Add] #161 - 셀 추가
JinUng41 6a09153
[Add] #161 - UI 추가 및 기타 수정
JinUng41 56d8026
[Refactor] #161 - PreRegister를 Register로 변경
JinUng41 c2964d4
[Chore] #161 - 변수명 변경
JinUng41 5dcc6f6
[Feat] #161 - 유즈케이스, 모델 구현
JinUng41 65dec68
[Feat] #161 - 뷰모델 로직 연결
JinUng41 6ba6fb6
[Style] #161 - 셀 UI 수정
JinUng41 629fe20
[Feat] #161 - 뷰모델 로직 연결
JinUng41 0a1c883
[Refactor] #161 - 루트뷰로 분리
JinUng41 0cf8cb6
[Feat] #161 - 커뮤니티 기능 구현
JinUng41 9331ce1
[Chore] #161 - 오타 수정
JinUng41 e9acb14
[Add] 커뮤니티 기능 구현 시 필요한 이미지 추가
youz2me df5c1f8
[Setting] 테스트플라이트 업데이트를 위해 기본 빌드 방식 Release로 변경
youz2me 50cb4dc
[Setting] 빌드 번호 변경
youz2me d1a9d31
[Setting] 인증서 AppStore 버전으로 변경
youz2me 5e255c0
Merge remote-tracking branch 'refs/remotes/origin/develop'
youz2me 220cd87
[Fix] #175 - 글 작성 화면 backgroundColor와 TextView의 backgroundColor 불일치 이…
youz2me 18a713d
[Fix] #175 - 홈 화면 좋아요 누르고 스크롤 시 좋아요가 사라지는 이슈 해결
youz2me d660a52
[Fix] #175 - 상세 페이지 댓글 표시가 안되는 이슈 해결
youz2me 5023fc8
[Fix] #175 - 홈 제목 링크 인식 안되는 이슈 해결
youz2me 5d35609
[Fix] #175 - 로그인 시 닉네임, 프로필 URL 없을 경우 온보딩 과정 거치도록 수정
youz2me bfe9648
[Fix] #175 - 온보딩 시 자음도 입력 가능하도록 설정
youz2me b9b5018
[Fix] #175 - 글 작성 유효성 검사 이슈 해결
youz2me 7144d60
[Fix] #175 - 댓글 작성 시 플레이스홀더가 댓글로 인식되는 문제 해결
youz2me eec98be
[Fix] # 175 - 댓글 버튼 터치 영역 반영 이슈 해결
youz2me 96edde7
[Fix] #175 - 리뷰 반영
youz2me File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Added profile URL validation when determining navigation path.
The code now requires that a user's profile URL must not be nil in addition to checking if they're a new user with a non-empty nickname. This adds more robust validation before deciding whether to navigate to onboarding or home screens.
However, the ternary operator is not ideal for calling void functions.
Replace the ternary with a clearer if-else statement:
📝 Committable suggestion
🧰 Tools
🪛 SwiftLint (0.57.0)
[Warning] 181-181: Using ternary to call Void functions should be avoided
(void_function_in_ternary)