[Feat] 스플래시 및 로그인 UI 구현 #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
JinUng41
approved these changes
Mar 17, 2025
Comment on lines
51
to
70
| private lazy var kakaoButtonHandler: UIActionHandler = { _ in | ||
| // TODO: 카카오 로그인 기능 구현 필요 | ||
| } | ||
|
|
||
| private lazy var appleButtonHandler: UIActionHandler = { _ in | ||
| // TODO: 애플 로그인 기능 구현 필요 | ||
|
|
||
| let noticeViewController = WableActionSheetViewController( | ||
| configuraton: .init( | ||
| title: "앗 잠깐!", | ||
| message: "와블은 온화하면서도 유쾌한 LCK 팬들이 모여 함께 즐기는 공간이에요.\n더 건강하고 즐거운 커뮤니티를 만들어 나가는데 함께 노력해주실거죠?", | ||
| confirmButtonTitle: "확인", | ||
| confirmAction: { completion in | ||
| // TODO: 온보딩 화면으로 전환 필요 | ||
| } | ||
| ) | ||
| ) | ||
|
|
||
| self.present(noticeViewController, animated: true) | ||
| } |
Collaborator
There was a problem hiding this comment.
UIActionHandler 프로퍼티를 ViewController가 계속 가지고 있어야 하는가 라는 관점에서 바라볼 때, 저는 아니라고 판단됩니다.
버튼에서 등록되기만 하면 되서 스택 영역에서 (함수 내) 선언되고 등록되기만 하면 될 것 같아요.
Member
Author
There was a problem hiding this comment.
UIAction 정도의 볼륨으로(클로저를 이용해) 구현할 수준이 아닌 것 같아 분리했는데 그러면 addTarget을 이용하는 게 조금 더 나은 것 같아 반영했습니다 !! 좋은 의견 감사합니다 ~!!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👻 PULL REQUEST
📄 작업 내용
👀 기타 더 이야기해볼 점
WableActionSheetViewController에서confirmAction을 설정했을 때 온보딩 화면으로 전환이 안되는 이슈가 있는데 리뷰하실 때 같이 설명해주시면 좋을 것 같아요! 해당 이슈는 온보딩 화면 구현할 때 연결해서 해결하도록 하겠습니다.🔗 연결된 이슈