-
Notifications
You must be signed in to change notification settings - Fork 0
[Feat] TabBarController, ToastView 작성 및 ConstraintMaker 익스텐션 구현 #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
2eaf269
[Feat] #118 - 탭 바, 네비게이션 바 및 adjust 값 적용을 위한 ConstraintMaker 익스텐션 구현
youz2me 842ed96
[Feat] #118 - TabBarController 디자인에 맞게 수정 및 SceneDelegate에 연결
youz2me 86fc640
[Feat] #118 - Toast 컴포넌트 구현
youz2me a0262c7
[Docs] #118 - NavigationView, ToastView에 주석 추가
youz2me 585a429
[Fix] #118 - 베타 이미지 표시 안되는 오류 및 1초 뒤 토스트 사라지는 오류 해결
youz2me d608181
[Fix] #118 - 코드 리뷰 반영
youz2me 65d86b0
[Fix] #118 - 알림 버튼 설정 코드 복구
youz2me File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| // | ||
| // LottieType.swift | ||
| // Wable-iOS | ||
| // | ||
| // Created by YOUJIM on 3/9/25. | ||
| // | ||
|
|
||
|
|
||
| import Foundation | ||
|
|
||
| enum LottieType: String { | ||
| case tab = "wable_tab" | ||
| case loading = "wable_loading" | ||
| case splash = "wable_splash" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
Wable-iOS/Presentation/WableComponent/Youjin/CommunityViewController.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| // | ||
| // CommunityViewController.swift | ||
| // Wable-iOS | ||
| // | ||
| // Created by YOUJIM on 3/10/25. | ||
| // | ||
|
|
||
|
|
||
| import UIKit | ||
|
|
||
| final class CommunityViewController: UIViewController { | ||
|
|
||
| } |
13 changes: 13 additions & 0 deletions
13
Wable-iOS/Presentation/WableComponent/Youjin/HomeViewController.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| // | ||
| // HomeViewController.swift | ||
| // Wable-iOS | ||
| // | ||
| // Created by YOUJIM on 3/10/25. | ||
| // | ||
|
|
||
|
|
||
| import UIKit | ||
|
|
||
| final class HomeViewController: UIViewController { | ||
|
|
||
| } |
13 changes: 13 additions & 0 deletions
13
Wable-iOS/Presentation/WableComponent/Youjin/OverviewViewController.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| // | ||
| // OverviewViewController.swift | ||
| // Wable-iOS | ||
| // | ||
| // Created by YOUJIM on 3/10/25. | ||
| // | ||
|
|
||
|
|
||
| import UIKit | ||
|
|
||
| final class OverviewViewController: UIViewController { | ||
|
|
||
| } |
13 changes: 13 additions & 0 deletions
13
Wable-iOS/Presentation/WableComponent/Youjin/ProfileViewController.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| // | ||
| // ProfileViewController.swift | ||
| // Wable-iOS | ||
| // | ||
| // Created by YOUJIM on 3/10/25. | ||
| // | ||
|
|
||
|
|
||
| import UIKit | ||
|
|
||
| final class ProfileViewController: UIViewController { | ||
|
|
||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이
extension의 영역이fileprivate으로 제한된다면, 외부에서 CGFloat 값을 선언 후 사용할 때adjusted와 같은 내용을 몰라도 되어서 은닉화를 이룰 수 있을 것 같습니다만, 어떻게 생각하실까요?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
앗 제가 이 부분을 본문에 적어둔다는 걸 깜빡했네요 ...!! UIView 익스텐션의
roundCorners메서드에서 cornerRadius를 설정하는 부분을 adjustedWidth에 맞춰 변경했는데요.filePrivate키워드를 사용하면 해당 익스텐션에서 adjustedWidth를 사용할 수 없기 때문에 키워드를 사용하지 않았습니다.