Skip to content

Conversation

@junseo511
Copy link
Member

@junseo511 junseo511 commented May 5, 2025

📌𝘐𝘴𝘴𝘶𝘦𝘴

📎𝘞𝘰𝘳𝘬 𝘋𝘦𝘴𝘤𝘳𝘪𝘱𝘵𝘪𝘰𝘯

  • 피드 좋아요 아이콘 하단 간격 조정

📷𝘚𝘤𝘳𝘦𝘦𝘯𝘴𝘩𝘰𝘵

Screen_recording_20250505_102449.mp4

💬𝘛𝘰 𝘙𝘦𝘷𝘪𝘦𝘸𝘦𝘳𝘴

Summary by CodeRabbit

  • New Features

    • 피드 작성 화면에 이미지를 가로로 스크롤하며 확인하고 개별 삭제할 수 있는 이미지 컨테이너가 추가되었습니다.
  • Style

    • 피드 및 활동 관련 레이아웃의 마진 속성이 간소화되어 UI 정렬이 개선되었습니다.
    • 피드 이미지 삭제용 아이콘이 새롭게 추가되었습니다.
  • Bug Fixes

    • 일부 레이아웃에서 디자인 타임용 가시성 속성이 제거되었습니다.
  • Documentation

    • 피드 비공개 안내 및 라벨 텍스트가 더 자연스럽게 수정되었습니다.

@junseo511 junseo511 added ♻️ [REFACTOR] 기존 코드를 리팩토링합니다. 🔮 법사 준서 labels May 5, 2025
@junseo511 junseo511 added this to the 탄생소소 milestone May 5, 2025
@junseo511 junseo511 self-assigned this May 5, 2025
@github-actions github-actions bot requested review from m6z1, s9hn and yeonjeen May 5, 2025 01:25
@junseo511 junseo511 changed the title Feat/669 refactor: 피드 좋아요 아이콘 하단 간격 조정 May 5, 2025
@junseo511 junseo511 changed the title refactor: 피드 좋아요 아이콘 하단 간격 조정 refactor: 피드 비공개 반영 관련 세부 디테일 수정 May 5, 2025
@coderabbitai
Copy link

coderabbitai bot commented May 23, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

새로운 Compose UI 컴포넌트 CreateFeedImageContainer가 추가되어 피드 생성 화면에서 이미지 목록을 가로 스크롤로 표시하고, 각 이미지에 삭제 버튼을 오버레이합니다. 여러 레이아웃 XML 파일에서 마진 속성이 간소화되고, 비공개 피드 관련 문자열 리소스가 수정 및 추가되었습니다. 또한, 삭제 아이콘 벡터 드로어블이 새로 추가되었습니다.

Changes

파일/경로 요약 변경 요약
app/src/main/java/com/into/websoso/ui/createFeed/component/CreateFeedImageContainer.kt CreateFeedImageContainer 등 Compose 함수 3종 추가, 이미지 목록 UI 및 삭제 콜백 구현
app/src/main/res/layout/activity_create_feed.xml 하드코딩된 문자열을 string 리소스로 변경, ComposeView 추가 및 레이아웃 제약 조건 조정
app/src/main/res/layout/item_feed.xml,
item_feed_detail_header.xml,
item_my_activity.xml
start/top/bottom 마진을 vertical 마진으로 통합, 디자인 타임 visibility 속성 제거
core/resource/src/main/res/drawable/ic_feed_remove_image.xml 이미지 삭제용 신규 벡터 드로어블 추가
core/resource/src/main/res/values/strings.xml feed_private_label 값 수정, create_feed_private 신규 문자열 리소스 추가

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant CreateFeedImageContainer
    participant CreateFeedImageBox

    User->>CreateFeedImageContainer: 이미지 목록 및 onRemoveClick 콜백 전달
    CreateFeedImageContainer->>CreateFeedImageBox: 각 이미지 렌더링
    User->>CreateFeedImageBox: 삭제 아이콘 클릭
    CreateFeedImageBox->>CreateFeedImageContainer: onRemoveClick(index) 호출
Loading

Assessment against linked issues

Objective Addressed Explanation
피드 좋아요 아이콘 하단 간격 조정 (#669)

Possibly related PRs

Suggested reviewers

  • yeonjeen
  • s9hn
  • m6z1

Poem

🐰
새 이미지는 가로로 쏙,
삭제 버튼도 톡톡!
마진은 깔끔하게 줄이고,
비공개 문구도 다듬었죠.
토끼도 기뻐 깡총깡총,
코드가 더 예뻐졌어요!
🖼️✨

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fabb54f and 3a43785.

📒 Files selected for processing (7)
  • app/src/main/java/com/into/websoso/ui/createFeed/component/CreateFeedImageContainer.kt (1 hunks)
  • app/src/main/res/layout/activity_create_feed.xml (4 hunks)
  • app/src/main/res/layout/item_feed.xml (3 hunks)
  • app/src/main/res/layout/item_feed_detail_header.xml (1 hunks)
  • app/src/main/res/layout/item_my_activity.xml (2 hunks)
  • core/resource/src/main/res/drawable/ic_feed_remove_image.xml (1 hunks)
  • core/resource/src/main/res/values/strings.xml (2 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

import androidx.compose.ui.res.painterResource
import androidx.compose.ui.tooling.preview.Preview
import androidx.compose.ui.unit.dp
import com.into.websoso.core.common.ui.component.AdaptationImage

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] standard:no-unused-imports reported by reviewdog 🐶
Unused import

@junseo511 junseo511 merged commit b66edea into develop May 23, 2025
0 of 2 checks passed
@m6z1 m6z1 deleted the feat/669 branch August 11, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

♻️ [REFACTOR] 기존 코드를 리팩토링합니다.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor: 피드 비공개 반영 관련 세부 디테일 수정

4 participants