[HOTFIX] 질문, 댓글 원격 알림의 알림 사운드 설정 #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaewonLeeKOR
requested review from
kyxxgsoo,
youngeun-dev,
tnals2384 and
a team
jaewonLeeKOR
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 타입(하나 이상의 PR 타입을 선택해주세요)
반영 브랜치
hotfix/#229/remoteNotiSoundless -> master
변경 사항
질문과 댓글 원격 알림이 알림 사운드가 발생하지 않던 버그를 수정했습니다.
@Schema(defaultValue = "default")를 통해 알림 사운드의 기본값을 지정하던 방식으로 인해 실제 서비스 구현에서 사용하는Builder패턴 방식의 기본값 설정법이 맞지 않아 사운드 값이 null로 전달되었습니다.@Builder.Default를 이용해 기본 알림사운드를 설정하는 방식으로 완료했습니다.