Split merge bit visualisation#34
Merged
EdNutting merged 7 commits intoTeachingTechnologistBeth:masterfrom Nov 4, 2018
Merged
Conversation
added 7 commits
November 2, 2018 10:11
…tter/easier/neater to use. Make them the default. Use Shift+Click to create curved lines. Backwards-compatibly load old files as curved lines. Save new files with type attribute. Old versions of model sim can open the new files but the lines will come out curved instead of straight.
…ith how it works.
… when one is possibly undriven.
…l output value of B/D bits. Note that this still isn't completely accurate to real-life because split-merge is wires which should back-propagate, but (as noted in comments in the code) we can't quite simulate reality.
Collaborator
Author
|
Also noticed that split/merge doesn't output the right value for B/D bits in some combinations because it was incorrectly merging undriven and driven bits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the label text of split-merge dynamic so that students can see the bits passing through.
This enables students to play with split-merge using switch inputs to see how bits pass through more concretely. Also enables faster debugging even while the clock is enabled.
The new labeling scheme also makes it really simple to find out whether a port of the split-merge is actually being driven or not (because the label reverts to, for example, XXDC, when it's not connected).