NRAM Edit window fixes#28
Merged
samtherussell merged 5 commits intoTeachingTechnologistBeth:masterfrom Oct 1, 2018
Merged
Conversation
Specifically when creating, editing or selecting links modules should be deselected at the start of the change not at the end (the latter is the current, confusing, indirect behaviour).
Builds upon consistent key handling support established by previous commits.
…ile menu of edit NRAM dialog Extract save function to avoid duplication.
Though issue does not reproduce in a local, fresh install of CentOS inside VirtualBox.
Collaborator
|
Good change. |
Collaborator
|
though haven't tested on the machines so can't close issue. |
Collaborator
Author
|
Tested on lab machines - fix confirmed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #4