Skip to content

Conversation

@rlanzafame
Copy link
Member

Did I capture the move part OK?
I found a few other things to clean up/improve also, hence the PR.

Did I capture the move part OK?
I found a few other things to clean up/improve also, hence the PR.
@rlanzafame rlanzafame marked this pull request as draft March 23, 2025 08:18
@rlanzafame rlanzafame marked this pull request as ready for review March 23, 2025 12:17
@rlanzafame
Copy link
Member Author

OK @Tom-van-Woudenberg I think I am done. I also added some example use cases.


In `call-deploy-book.yml` itself you can specify the trigger for this workflow. By default, a push to any branch triggers the workflow. You can limit the branches or subdirectories.

## Common Usage Examples
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part is also covered slightly differnetly by https://teachbooks.io/manual/installation-and-setup/versions_URLs.html. @rlanzafame , what do you think? Should we have it in both places?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should move the tips into this deploy-book-workflow README/book-page?

Copy link
Member

@Tom-van-Woudenberg Tom-van-Woudenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, but ready to merge

@Tom-van-Woudenberg Tom-van-Woudenberg merged commit 672aecc into move Mar 23, 2025
@Tom-van-Woudenberg Tom-van-Woudenberg deleted the rlanzafame-patch-1 branch March 23, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants