Skip to content

Conversation

@severinbratus
Copy link
Contributor

Resolves #1

@rlanzafame
Copy link
Member

Looks good to me, I am excited to use it! (but don't have time at the moment - I'll let Tom sign off on this one :))

Copy link
Member

@Tom-van-Woudenberg Tom-van-Woudenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

I've changed one thing (double / somewhere) and tried implementing something else (but failed): can you give the full link in the aliases table? So https://teachbooks.github.io/.../alias --> https://teachbooks.github.io/.../target instead of only alias --> target

And maybe show the branches deployed table only when the process is finished? Otherwise it might give the impression that the urls are already available, even if it finishes at a later stage.

@severinbratus
Copy link
Contributor Author

Awesome!

I've changed one thing (double / somewhere) and tried implementing something else (but failed): can you give the full link in the aliases table? So https://teachbooks.github.io/.../alias --> https://teachbooks.github.io/.../target instead of only alias --> target

And maybe show the branches deployed table only when the process is finished? Otherwise it might give the impression that the urls are already available, even if it finishes at a later stage.

Fixed both in new commit, please see is this summary looks OK: https://github.com/TeachBooks/testable-template/actions/runs/8723981979

@Tom-van-Woudenberg Tom-van-Woudenberg merged commit 5e3f32a into main Apr 19, 2024
@Tom-van-Woudenberg Tom-van-Woudenberg deleted the feat/1/actions-summaries branch April 19, 2024 15:33
@severinbratus severinbratus restored the feat/1/actions-summaries branch April 19, 2024 16:16
@Tom-van-Woudenberg Tom-van-Woudenberg deleted the feat/1/actions-summaries branch April 26, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

List branches deployed in an Actions summary

4 participants