-
Couldn't load subscription status.
- Fork 3
Actions summaries #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks good to me, I am excited to use it! (but don't have time at the moment - I'll let Tom sign off on this one :)) |
I'm brave....
Learning while doing
@severinbratus , maybe this is stupid
Otherwise I'll hand over again to severin
This reverts commit 7600afc.
This reverts commit 658d729.
This reverts commit 9b4dd54.
This reverts commit 272289c.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
I've changed one thing (double / somewhere) and tried implementing something else (but failed): can you give the full link in the aliases table? So https://teachbooks.github.io/.../alias --> https://teachbooks.github.io/.../target instead of only alias --> target
And maybe show the branches deployed table only when the process is finished? Otherwise it might give the impression that the urls are already available, even if it finishes at a later stage.
Fixed both in new commit, please see is this summary looks OK: https://github.com/TeachBooks/testable-template/actions/runs/8723981979 |
Resolves #1