Enable submodules #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tom-van-Woudenberg
requested changes
Apr 17, 2024
There was a problem hiding this comment.
@CasparJungbacker It doesn't werk yet, I added the with-recursive-thingy branch which points to this branch https://github.com/TeachBooks/Nested-Books/blob/with-recursive-thingy/.github/workflows/call-deploy-book.yml#L18. However, the build website doesn't show the page: https://teachbooks.github.io/Nested-Books/with-recursive-thingy/intro.html
This reverts commit 066f73c.
Robert and I discussed that one layer should always be anough
|
@CasparJungbacker I fixed it, there were multiple checkouts in the workflow, needed to be at another fun. The process was fun:p |
Tom-van-Woudenberg
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nested books rely on submodules, but these are not cloned automatically by the checkout action. Hence, pages from "sub-books" did not appear in book that used this feature (see TeachBooks/Nested-Books#1).
This PR enables the option to also checkout submodules in the checkout stage of CI.
(cc @Tom-van-Woudenberg)