-
Couldn't load subscription status.
- Fork 3
Restore previous successful build on failure #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This requires for sure a notification in the summary as well (linked to #24 ), otherwise users might be confused that changes are not visible in the build book.
What if the caches isn't available any more (they expire right?)? I first thought that you might rebuild the previous commit which was succesful (if that one is available). However, book builds might also fail because a package is updated causes inconsistensies. The requirements.txt might still be the same, but the resulting environment might be different. In that case rebuilding with the previous commit won't work either...
So I guess when the cache isn't available any more, make it very clear in the summary that this branch is not published (also related to #24 )
OK! the way I see this: we have a column with either |
@severinbratus, sounds good! |
|
Many commits later, here is what an example summary it looks like: https://github.com/TeachBooks/testable-template/actions/runs/9112678442 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since only one alias works, I adapted the manual. Could you remove the default draft:main alias as it will probably not be used a lot?
After that you can merge this directly
Idea: Use
actions/cache/restoreaction if the build step fails, with a bogus key (none) and partial restore keyhtml-build-<branchname>, which would match the most recent build on the branch. For technical details see https://docs.github.com/en/actions/using-workflows/caching-dependencies-to-speed-up-workflows#matching-a-cache-keyFor an example see: https://github.com/TeachBooks/testable-template/actions/runs/8970098300 Build failed, previous version still live at https://teachbooks.github.io/testable-template/feat-20/intro.html
Resolves #25, #24