Skip to content
This repository was archived by the owner on Mar 25, 2025. It is now read-only.

#4 Convetion proposal#5

Merged
PTKu merged 2 commits intoTcOpenGroup:devfrom
jozefchmelar:dev
Nov 2, 2020
Merged

#4 Convetion proposal#5
PTKu merged 2 commits intoTcOpenGroup:devfrom
jozefchmelar:dev

Conversation

@jozefchmelar
Copy link
Contributor

According to #4 I propose some changes.

#  Member naming  & Type Naming

I don't see a benefit in using prefix. It doesn't help me in any way. 

## Member Variables

Class (FB) member variables should be hidden and begin with small name 
~~~Pascal
    VAR
        {attribute 'hide'}
        trigger : BOOL;
        {attribute 'hide'}
        counter : INT;
          {attribute 'hide'}
        analogStatus : AnalogStatus;
    END_VAR
~~~
@jozefchmelar jozefchmelar marked this pull request as ready for review October 30, 2020 10:31
@jozefchmelar jozefchmelar mentioned this pull request Oct 30, 2020
4 tasks
@jozefchmelar
Copy link
Contributor Author

Member naming & Type Naming

I don't see a benefit in using prefix. It doesn't help me in any way.

Member Variables

Class (FB) member variables should be hidden and begin with small name

    VAR
        {attribute 'hide'}
        trigger : BOOL;
        {attribute 'hide'}
        counter : INT;
          {attribute 'hide'}
        analogStatus : AnalogStatus;
    END_VAR

@PTKu PTKu merged commit 0d50c86 into TcOpenGroup:dev Nov 2, 2020
PTKu added a commit that referenced this pull request Apr 29, 2021
Updates from tcopengroup
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants