Skip to content

Conversation

@arolfes
Copy link
Contributor

@arolfes arolfes commented Apr 18, 2024


For the submitter:

Verified by the reviewer:

  • Commit message format → ADPT-XXX: Your commit message.
  • Submitter's update to documentation is sufficient
  • SonarCloud analysis meets our standards
  • Update of the current release notes reflects changes
  • PR fulfills the ticket
  • Edge cases and unwanted side effects are tested
  • Readability

Copy link
Contributor

@ryzheboka ryzheboka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Could you explain some changes to the int-test-standalone.xml? I couldn't understand them myself. Especially the new usage of "ApplicationDomain" and "ManagementDomain"

<logger category="com.arjuna">
<level name="WARN"/>
</logger>
<logger category="com.networknt.schema">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you add this new logger?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right, not needed

</permission-set>
</permission-sets>
<http>
<http-authentication-factory name="application-http-authentication"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you add this new http-authenrication-factory and the new security-domain?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied it from original config file

@arolfes
Copy link
Contributor Author

arolfes commented Apr 19, 2024

Hello @ryzheboka ,

Thanks for the PR! Could you explain some changes to the int-test-standalone.xml? I couldn't understand them myself. Especially the new usage of "ApplicationDomain" and "ManagementDomain"

i downloaded the Version 31.0.1.Final from Wildfly manually. Then I compared the original config file with our config file. Everything new I added to our config file.

Please see attachment. standalone-full.xml.txt

@arolfes arolfes merged commit 9656b71 into Taskana:master May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants