Skip to content

Conversation

@gitgoodjhe
Copy link
Contributor

@gitgoodjhe gitgoodjhe commented Jul 8, 2022


For the submitter:

Verified by the reviewer:

  • Commit message format → ADPT-XXX: Your commit message.
  • Submitter's update to documentation is sufficient
  • SonarCloud analysis meets our standards
  • Update of the current release notes reflects changes
  • PR fulfills the ticket
  • Edge cases and unwanted side effects are tested
  • Readability

Copy link
Contributor

@holgerhagen holgerhagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a test for the default initialization to -1?

And maybe we should have a second look at the names. Is it really correct that we do have such many "ReferencedTask"s?

holgerhagen
holgerhagen previously approved these changes Jul 11, 2022
@gitgoodjhe
Copy link
Contributor Author

@gitgoodjhe gitgoodjhe merged commit 4b3c8cb into Taskana:master Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants