Simplify our code by using std::cout from ESP32-S3 runtime environment
#110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent. The runtime environment bundled within the [GCC Toolchain for Espressif ESP32-S3 Xtensa MCUs](https://registry.platformio.org/tools/espressif/toolchain-xtensa-esp32s3) apparently already maps `std::cout` to serial interface. No need to maintain our own version of it.
dhebbeker
added
the
code improvement
dhebbeker
commented
Feb 23, 2024
There was a problem hiding this comment.
Before:
RAM: [== ] 24.0% (used 78560 bytes from 327680 bytes)
Flash: [== ] 24.1% (used 804141 bytes from 3342336 bytes)
After:
RAM: [== ] 23.8% (used 78128 bytes from 327680 bytes)
Flash: [== ] 24.0% (used 803721 bytes from 3342336 bytes)
Note: The job for generating the documentation fails because of the branch name. This is irrelevant and may be ignored.
FiveTeethless
approved these changes
Feb 25, 2024
dhebbeker
deleted the
feature/87-use_`std__cout`_instead_of_`serial_port__cout`
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The runtime environment bundled within the GCC Toolchain for Espressif ESP32-S3 Xtensa MCUs apparently already maps
std::coutto serial interface. No need to maintain our own version of it.This resolves #87.