Fix outmsg import stmt, doc nodename err #12
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HansOlavS
reviewed
Jan 18, 2021
| ```Python | ||
| import uuid | ||
| from target365_sdk import ApiClient | ||
| from target365_sdk.api_client import OutMessage |
Contributor
There was a problem hiding this comment.
According to the tests the correct import for OutMessage is "from ..models.out_message import OutMessage"
Contributor
Author
There was a problem hiding this comment.
This will not work in client code, because ..models.out is a library-internal reference. For clients target365_sdk will exist in a pip store, not in a relative path.
Contributor
|
@paalvibe Thanks for the PR. I agree that the trailing slash in the base_uri shouldn't be required and be added by the SDK if missing. I'll close this PR for now and fix that ASAP instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import of OutMessage class was unclear.
Confusing baseuri error documented. I suspect it would be better to expect base url to not have trailing slash, or auto-add it.