Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure it does not break with null values. #16

Merged
merged 1 commit into from
Sep 24, 2023

Conversation

haringsrob
Copy link
Contributor

There's a case where the old value can be null, this simply checks/defaults to an empty array.

@what-the-diff
Copy link

what-the-diff bot commented Sep 22, 2023

PR Summary

  • Modification of key-value template
    The template file in the path resources/views/tables/columns/key-value.blade.php has been updated.

  • Improvement of Foreach Loop Condition
    An enhancement was made to the existing loop condition. Now, in case the expected value is not found, it will use an empty array as a fallback. This will prevent any potential errors due to a null value.

  • Changes to Visual Elements
    The styling of certain visual elements has been updated. The span element has been given a new class to manage the whitespace. Additionally, the text and background colours have been modified to improve legibility and aesthetics.

  • Retained twig variable
    The twig variable {{ $key }}, used for constructing dynamic content on the site, has remained unchanged.

Copy link
Contributor

@andreia andreia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haringsrob Thank you! :)

@andreia andreia merged commit ba5518b into TappNetwork:main Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants