Add option to show/hide the icon #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpmmmurphy
requested changes
Mar 3, 2017
| @@ -176,7 +178,7 @@ public void onAnimationStart(final Animation animation) { | |||
| @Override | |||
| public void onAnimationEnd(final Animation animation) { | |||
| //Start the Icon Animation once the Alert is settled | |||
| if (enableIconPulse) { | |||
| if (enableIconPulse && showIcon) { | |||
There was a problem hiding this comment.
Update here to check the visibility of the icon, instead of using a boolean flag.
if (enableIconPulse && ivIcon.getVisibility() == VISIBLE) {}
| * @param showIcon True to show the icon, false otherwise | ||
| */ | ||
| public void showIcon(final boolean showIcon) { | ||
| this.showIcon = showIcon; |
| @@ -55,6 +55,8 @@ | |||
| private boolean enableIconPulse = true; | |||
| private boolean enableInfiniteDuration; | |||
|
|
|||
| private boolean showIcon = true; | |||
* Update CHANGELOG and version
|
@kpmmmurphy Thanks for the feedback. I updated the PR. |
kpmmmurphy
approved these changes
Mar 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.