Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: queue null check & queue track listing #280

Merged
merged 1 commit into from
Jun 2, 2024

Conversation

samdammers
Copy link
Contributor

Queue Check Bug:
When running the queue command before any tracks are added, it would encounter an exception:

TypeError: Cannot read properties of null (reading 'currentTrack')

Replaced the undefined check with a broader null check, now correctly returns that there are no songs.
image

Queue List Bug:
When listing the queue, it now returns just [object Object]
image

Refactored to iterate track list and display:
image

Copy link
Owner

@TannerGabriel TannerGabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. LGTM

@TannerGabriel TannerGabriel merged commit edb283b into TannerGabriel:master Jun 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants