Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bot not disconnecting after queue finished #273

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

TannerGabriel
Copy link
Owner

Delete queue when receiving the emptyQueue event so that the bot disconnects from the voice channel.

Signed-off-by: TannerGabriel <gabrieltanner.code@gmail.com>
@TannerGabriel
Copy link
Owner Author

@elboletaire can you please validate that this fixes the disconnect problem you mentioned in #264

@elboletaire
Copy link

I can't easily try it RN, but the changes look good; I can also confirm the message ✅ | Queue finished! was being showed always when the queue finished, so disconnecting there should do the trick.

If you still want me to give it a try, I'll need some time (I'd try to do it in a few hours, but could be another day too, depending on the workload).

@TannerGabriel
Copy link
Owner Author

Thanks for the quick response and willingness to test, but you can take your time with it since it is nothing time-critical; a few days or a week are totally fine. I can also merge it without you testing since it worked on my machine - however you prefer.

@TannerGabriel TannerGabriel marked this pull request as ready for review February 13, 2024 10:31
@elboletaire
Copy link

elboletaire commented Feb 13, 2024

I'd say to merge it then, I'll also be able to test it more easily once we have the docker image published ;) (well in this case, recheck it more than test it xD)

@TannerGabriel TannerGabriel merged commit cf3ae68 into master Feb 13, 2024
2 checks passed
@TannerGabriel TannerGabriel deleted the fix/disconnect-problem branch February 13, 2024 10:58
@elboletaire
Copy link

update: works like a charm 👌🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants