Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix activityType #199

Merged
merged 3 commits into from
Nov 30, 2022
Merged

Fix activityType #199

merged 3 commits into from
Nov 30, 2022

Conversation

Bygrilinho
Copy link
Contributor

Default config sets activityType as a string, so presence won't work

@TannerGabriel
Copy link
Owner

Thank you for the contribution and for letting me know that the feature is not working anymore. I would prefer if we could change the functionality inside of the index.js file. Here is a working example:

client.user.setPresence({
    activities: [{ name: config.activity, type: Number(config.activityType) }],
    status: Discord.PresenceUpdateStatus.Online,
  });

This also changes the status since that also does not work anymore.

@Bygrilinho
Copy link
Contributor Author

Sounds good! Would status also go in config.json? For choosing idle, dnd... Or you'd keep it online only?

@TannerGabriel
Copy link
Owner

Online should be sufficient for now.

Copy link
Owner

@TannerGabriel TannerGabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TannerGabriel TannerGabriel merged commit 9dd09f8 into TannerGabriel:master Nov 30, 2022
@Bygrilinho Bygrilinho deleted the child-1 branch November 30, 2022 19:15
Bygrilinho added a commit to Bygrilinho/abacatron that referenced this pull request Dec 30, 2022
* Fix activityType

* Revert "Fix activityType"

This reverts commit 58455f6.

* Fix activityType and status
MoeSW added a commit to MoeSW/MUPPETBOT that referenced this pull request Mar 6, 2023
* fix: Discord opus dependency issue

Signed-off-by: TannerGabriel <gabrieltanner.code@gmail.com>

* Fix activityType (TannerGabriel#199)

* Fix activityType

* Revert "Fix activityType"

This reverts commit 58455f6.

* Fix activityType and status

* Switch Dockerfile to distroless base image (TannerGabriel#209)

* Switch Dockerfile to distroless image

* Docker: Compress ffmpeg with upx

* feat: add docker build github action (TannerGabriel#208)

* feat: add docker build github action

should use github.actor

prepare for upstream pr

* update readme

* Update README.md

* fix: Docker build action (TannerGabriel#211)

* fix: Docker build action repo name

Signed-off-by: TannerGabriel <gabrieltanner.code@gmail.com>

* Add workflow dispatch to docker build action

Signed-off-by: TannerGabriel <gabrieltanner.code@gmail.com>

---------

Signed-off-by: TannerGabriel <gabrieltanner.code@gmail.com>

* Update index.js (TannerGabriel#213)

Fix for player autopausing after quitting after 30-60s.

Androz2091/discord-player#1630 (comment)

---------

Signed-off-by: TannerGabriel <gabrieltanner.code@gmail.com>
Co-authored-by: TannerGabriel <gabrieltanner.code@gmail.com>
Co-authored-by: Bygrilinho <20670349+Bygrilinho@users.noreply.github.com>
Co-authored-by: Florentin Schäfer <florentin.schaefer@gmail.com>
Co-authored-by: Fredrick Myrvoll <fredrickmyrvoll@gmail.com>
Co-authored-by: smclean117 <90870055+smclean117@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants