Skip to content

feat: v2 - runview fast preview button for outputs#2524

Draft
maxy-shpfy wants to merge 1 commit into
07-14-feat_v2_-_runview_tools_window_to_become_a_panelfrom
07-14-feat_v2_-_runview_fast_preview_button_for_outputs
Draft

feat: v2 - runview fast preview button for outputs#2524
maxy-shpfy wants to merge 1 commit into
07-14-feat_v2_-_runview_tools_window_to_become_a_panelfrom
07-14-feat_v2_-_runview_fast_preview_button_for_outputs

Conversation

@maxy-shpfy

@maxy-shpfy maxy-shpfy commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

Description

Adds artifact preview buttons directly to task output rows in the RunView pipeline graph. When a task has completed execution, each output row now shows an ArtifactVisualizer trigger inline, allowing users to preview output artifacts without opening the full Artifacts panel.

To support this without coupling the shared TaskNodeCard to execution-specific logic, an OutputActionsContext was introduced. This context accepts an optional render function for per-output actions. RunViewTaskNode provides this renderer, which fetches execution artifacts via getExecutionArtifacts and maps each output to a RunViewOutputPreview component. The preview is suppressed when the artifact is missing, has no URI or inline value, or exceeds 50 MB.

Related Issue and Pull requests

Type of Change

  • Bug fix
  • New feature
  • Improvement
  • Cleanup/Refactor
  • Breaking change
  • Documentation update

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

Screen Recording 2026-07-14 at 1.46.15 PM.mov (uploaded via Graphite)

Test Instructions

  1. Open a completed pipeline run in RunView.
  2. Inspect task nodes that have outputs with artifacts.
  3. Verify that a preview trigger appears inline next to each eligible output name.
  4. Confirm that outputs without artifacts, with no URI/inline value, or exceeding 50 MB do not show a preview trigger.
  5. Verify that clicking the preview trigger opens the artifact visualizer correctly.
  6. Confirm that task nodes in non-RunView contexts (e.g., the pipeline editor) are unaffected and show no preview triggers.

Additional Comments

The OutputActionsContext is intentionally generic so other views can inject their own per-output actions in the future without modifying TaskNodeCard.

@github-actions

github-actions Bot commented Jul 14, 2026

Copy link
Copy Markdown

🎩 Preview

A preview build has been created at: 07-14-feat_v2_-_runview_fast_preview_button_for_outputs/c31b783

Copy link
Copy Markdown
Collaborator Author

@maxy-shpfy maxy-shpfy force-pushed the 07-14-feat_v2_-_runview_tools_window_to_become_a_panel branch from 4c23003 to c53483e Compare July 14, 2026 20:44
@maxy-shpfy maxy-shpfy force-pushed the 07-14-feat_v2_-_runview_fast_preview_button_for_outputs branch from 00012e0 to 2f22614 Compare July 14, 2026 20:44

Copy link
Copy Markdown

I dig it! 👏

@morgan-wowk morgan-wowk left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Top-hatting feedback:

  • It does not feel like a button right now. Either there is no hover effect or it is very faint. This makes it difficult to know where the selectable region is that would trigger the button click.

@Mbeaulne Mbeaulne force-pushed the 07-14-feat_v2_-_runview_tools_window_to_become_a_panel branch from c53483e to 208dffd Compare July 15, 2026 17:52
@Mbeaulne Mbeaulne force-pushed the 07-14-feat_v2_-_runview_tools_window_to_become_a_panel branch from 208dffd to fefd7e3 Compare July 15, 2026 17:53
@Mbeaulne Mbeaulne force-pushed the 07-14-feat_v2_-_runview_fast_preview_button_for_outputs branch from 2f22614 to c31b783 Compare July 15, 2026 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants