Skip to content

Conversation

@ethelynmatias
Copy link

@ethelynmatias ethelynmatias commented Sep 2, 2025

Related:


Warning

DO NOT MERGE ON MAIN, REVIEW ONLY

@eliot-akira please do not merge it on main this will only apply for new plugins that should be uploaded on cloud.

I successfully pushed the zip on cloud. Oh the only missing the changelog details do we have that?

After Release script:
image

Uploaded on cloud website after release
image

@eliot-akira
Copy link
Contributor

eliot-akira commented Sep 2, 2025

successfully pushed the zip on cloud

Excellent, glad to see you were able to extend the pipeline script for your purpose.

Instead of running curl in a child process, it would be more efficient to use the native Fetch API available in the JavaScript runtime. But maybe it's too much effort to convert it, like attaching a file through FormData.

We can leave that for later, I'll create an issue as reminder.


missing the changelog details

You'll need to extract the change log from the plugin's readme.txt.

For example:

== Changelog ==

= 0.1.0 =

Release Date: 2025-01-01

- Initial release

https://github.com/TangibleInc/example-plugin-with-cloud/blob/c1d6fce17d6c1dde00bd6b13f291602b4e6c6ab5/readme.txt#L20-L26

The easiest way to extract it would be to fs.readFile() the file content; split it at the keyword == Changelog ==; then split the rest into lines (or regular expression to split at version header) and gather the newest version's change log.

@eliot-akira
Copy link
Contributor

eliot-akira commented Sep 2, 2025

By the way, what's the difference between Plugin ID and Product ID?

@eliot-akira eliot-akira changed the title Feature/cloud Cloud integration: Deploy version release Sep 2, 2025
@ethelynmatias
Copy link
Author

ethelynmatias commented Sep 15, 2025

@eliot-akira

By the way, what's the difference between Plugin ID and Product ID?

The product id is the main product the plugin_id is the plugin uploads id
image

There can be multiple product on the plugin. Product & Variation
image

@eliot-akira
Copy link
Contributor

There can be multiple product on the plugin

I see, that makes sense. Thanks for the explanation.


By the way, in the review comments I wrote above, you can click "Commit suggestion" for each one and it will create Git commits to make the change.

image

@ethelynmatias
Copy link
Author

@eliot-akira resolved your suggestions here, Thank you :)

@eliot-akira
Copy link
Contributor

eliot-akira commented Sep 16, 2025

Yeah, I see you're getting closer with the plugin change log.

From the example plugin's Actions log:

For the latest build, in the section "After release script":

The change log is still getting the entire readme.txt. To extract the change list for the newest version only, after this line:

changelog = await fs.readFile(readmePath, 'utf8')

We can split the text by lines, and go through them to gather the specific lines we need. I'll make a code suggestion, you can see how it might work.

ethelynmatias and others added 2 commits September 17, 2025 12:24
Co-authored-by: 3λiȯ+ <me@eliotakira.com>
Co-authored-by: 3λiȯ+ <me@eliotakira.com>
@ethelynmatias
Copy link
Author

@eliot-akira can I use another changelog.txt for changelog ? coz for readme there will be installation process @ghen-arvesu

@eliot-akira
Copy link
Contributor

eliot-akira commented Sep 17, 2025

can I use another changelog.txt for changelog?

WordPress plugins have a standard format for readme.txt, whose content is used in various places including plugin update notices. So it won't make sense to have the change log duplicated in a separate file.

for readme there will be installation process

Could you elaborate on what this means, and how it relates to the change log?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants