fix: align startIndex & endIndex to lanes for masonry mode#933
fix: align startIndex & endIndex to lanes for masonry mode#933piecyk merged 3 commits intoTanStack:mainfrom
Conversation
|
Without fix With fix |
|
Easy way for reproducing bug - just set overscan 0 for MasonryVerticalVirtualizerVariable example https://tanstack.com/virtual/latest/docs/framework/react/examples/variable |
piecyk
left a comment
There was a problem hiding this comment.
Thanks, looks good, let's update the condition and we can merge it.
packages/virtual-core/src/index.ts
Outdated
| endIndex++ | ||
| } | ||
|
|
||
| if (lanes != 1) { |
There was a problem hiding this comment.
| if (lanes != 1) { | |
| if (lanes > 1) { |
There was a problem hiding this comment.
Thanks for the feedback, I fixed it
|
Hi! I'm I would like to apply some automated changes to this pull request, but it looks like I don't have the necessary permissions to do so. To get this pull request into a mergeable state, please do one of the following two things:
|
|
View your CI Pipeline Execution ↗ for commit a2cde5d.
☁️ Nx Cloud last updated this comment at |
|
@Azq2 thanks, btw did you noticed the formatting check? |
|
@piecyk Yes, I missed it. Now it's fixed. |
Fix for #573