fix(virtual-core): prevent scrollToIndex crash on unmount#1130
Closed
piecyk wants to merge 2 commits intoTanStack:mainfrom
Closed
fix(virtual-core): prevent scrollToIndex crash on unmount#1130piecyk wants to merge 2 commits intoTanStack:mainfrom
piecyk wants to merge 2 commits intoTanStack:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 3c44034 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
View your CI Pipeline Execution ↗ for commit 3c44034
☁️ Nx Cloud last updated this comment at |
Collaborator
Author
|
Closing this PR since the changes will be addressed in #1129 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
Guard
scrollToIndexso that scheduled scroll work becomes a no-op when the scroll container is no longer available (e.g. component unmounted).Previously, scroll work scheduled via
requestAnimationFramecould throw if the scroll element was removed before execution.This aligns the behavior with expectations for an imperative helper: if there’s no scroll container, do nothing rather than crash.
✅ Checklist
pnpm run test:pr.🚀 Release Impact