Skip to content

fix(table-core): expand rows with manual pagination#6440

Draft
KevinVandy wants to merge 1 commit into
betafrom
agent/fix-5110-manual-pagination-expansion
Draft

fix(table-core): expand rows with manual pagination#6440
KevinVandy wants to merge 1 commit into
betafrom
agent/fix-5110-manual-pagination-expansion

Conversation

@KevinVandy

@KevinVandy KevinVandy commented Jul 18, 2026

Copy link
Copy Markdown
Member

Summary

  • expand already-paginated parent rows when manual pagination bypasses the client pagination row model
  • keep deferring expansion when client pagination is responsible for slicing parents before inserting descendants
  • include manualPagination in the expanded row-model memo dependencies
  • add a regression test for manualPagination with paginateExpandedRows disabled

Why

With manualPagination enabled, the table assumes incoming data already represents a page and bypasses createPaginatedRowModel. When paginateExpandedRows was false, createExpandedRowModel also deferred expansion to that skipped pagination stage, so expanded children never appeared.

This preserves the documented behavior that expanded children remain on their parent page without consuming page slots, while making it work for data paginated outside the table.

Validation

  • 52 table-core test files passed (1,005 tests)
  • table-core TypeScript checks passed, including declaration emit
  • table-core ESLint passed
  • Prettier check passed

Closes #5110

@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 976555fa-7e3e-4a99-8134-fabdfc21bcf4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch agent/fix-5110-manual-pagination-expansion

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented Jul 18, 2026 •
edited
Loading

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 58baef6

Command Status Duration Result
nx affected --targets=test:eslint,test:sherif,t... ✅ Succeeded 8m 7s View ↗
nx run-many --targets=build --exclude=examples/** ✅ Succeeded 49s View ↗

☁️ Nx Cloud last updated this comment at 2026-07-18 00:39:59 UTC

@pkg-pr-new

pkg-pr-new Bot commented Jul 18, 2026

Copy link
Copy Markdown
More templates

@tanstack/alpine-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/alpine-table@6440

@tanstack/angular-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/angular-table@6440

@tanstack/angular-table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/angular-table-devtools@6440

@tanstack/ember-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/ember-table@6440

@tanstack/lit-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/lit-table@6440

@tanstack/match-sorter-utils

npm i https://pkg.pr.new/TanStack/table/@tanstack/match-sorter-utils@6440

@tanstack/preact-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/preact-table@6440

@tanstack/preact-table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/preact-table-devtools@6440

@tanstack/react-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/react-table@6440

@tanstack/react-table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/react-table-devtools@6440

@tanstack/solid-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/solid-table@6440

@tanstack/solid-table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/solid-table-devtools@6440

@tanstack/svelte-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/svelte-table@6440

@tanstack/table-core

npm i https://pkg.pr.new/TanStack/table/@tanstack/table-core@6440

@tanstack/table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/table-devtools@6440

@tanstack/vue-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/vue-table@6440

@tanstack/vue-table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/vue-table-devtools@6440

commit: 58baef6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Expanding is not working with manualPagination and with truthy paginateExpandedRows

1 participant

@KevinVandy