fix: Add a missing guard for 'undefined' in the getFilteredRowModel function.#5555
Merged
KevinVandy merged 1 commit intoTanStack:mainfrom May 14, 2024
Merged
fix: Add a missing guard for 'undefined' in the getFilteredRowModel function.#5555KevinVandy merged 1 commit intoTanStack:mainfrom
KevinVandy merged 1 commit intoTanStack:mainfrom
Conversation
KevinVandy
approved these changes
May 14, 2024
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 96a50bb. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I had a small issue with GlobalFilter while trying to use filter values with the createTable function.
I encountered a problem related to an undefined value in getFilteredRowModel
I found a missing undefined guard in getFilteredRowModel.ts.
There is another guard (with starting semicolon?) in the same function
table/packages/table-core/src/utils/getFilteredRowModel.ts
Line 31 in 047348f
but it was missing in the section I committed.
After committing this change, everything works fine for me now.
P.S. Thanks for the awesome project. I am really enjoying TanStack Table.