feat: new sortUndefined last and first options#5486
Merged
KevinVandy merged 1 commit intomainfrom Apr 13, 2024
Merged
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 7e965ec. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
This was referenced May 24, 2024
This was referenced Jun 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr gives new "official" options to force undefined column values to either the bottom or top rows of a table when a sort is performed on those columns when the
sortUndefinedis set to'last'or'first'in the column option.This used to be behavior out of the box with
sortUndefined: 1, but was changed 10 months ago to not count undefined values. This PR will not have any breaking changes, but will allow those who preferred the old behavior more with an explicit option.