fix: ts support for all optional keys in data model#5283
Merged
KevinVandy merged 5 commits intoTanStack:mainfrom Feb 28, 2024
Merged
Conversation
KevinVandy
approved these changes
Feb 28, 2024
Member
KevinVandy
left a comment
There was a problem hiding this comment.
I tested this for a while, and it looks good. We can revert if something pops up
☁️ Nx Cloud ReportCI is running/has finished running commands for commit b4ea6f3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5272
Is
object extends Tdifferent thanT extends object?Before: Following basic example, if Person had only optional fields DeepKeys would use
object extends Tand inferstringAfter: When that got removed, the same case will fall under
T extends objectand will nicely infer key names.Did I missed something obvious? It was probably there for a reason