fix react-table-config.d.ts #1582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that pulling the types directly from a package slightly changes how visible they are to the consuming application. This makes sense, previously we explicitly adding the react-table module to the global namespace an so didn't need explicit imports, but now that's not the case. So add explicit imports.
ChristianMurphy
approved these changes
Oct 9, 2019
|
Hey guys (@ggascoigne) wonderful job about adding the typings, is the documentation in tyescript.md outdated already after this? I'm still struggling to understand what's the right way to use this lib along typescript, also I guess it's worthy to link the typescript doc (if updated) in the main readme, what do you think? |
Contributor
Author
|
@dbertella having seen your PR I think that you've got it all sorted out, but just in case I updated my simple example too: #1534 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that pulling the types directly from a package slightly
changes how visible they are to the consuming application. This makes
sense, previously we explicitly adding the react-table module to the
global namespace an so didn't need explicit imports, but now that's not
the case. So add explicit imports.