columnHelper.accessor Type issue

[opti21]

Describe the bug

When defining the columns for the table, columnHelper.accessor seems to cause a type issue. Although, table seems to render fine.

Type error:
Type 'ColumnDef<Room, string>' is not assignable to type 'ColumnDef<Room, unknown>'.

StackBlitz Type Error:

Type instantiation is excessively deep and possibly infinite.(2589)
(property) accessor: <"id", string>(accessor: "id", column: Omit<ColumnDef<Room, string>, "accessorKey">) => ColumnDef<Room, string>

Your minimal, reproducible example

https://stackblitz.com/edit/github-sq9c9a?file=pages%2Findex.tsx

Steps to reproduce

Line 22 on index.tsx

Expected behavior

No type error

How often does this bug happen?

Every time

Screenshots or Videos

No response

Platform

Windows 11 Pro
Chrome: Version 103.0.5060.134 (Official Build) (64-bit)

react-table version

8.5.2

TypeScript version

4.7.4

Additional context

No response

Terms & Code of Conduct

• I agree to follow this project's Code of Conduct
• I understand that if my bug cannot be reliable reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.

[dustinwdev]

We just installed the latest version with a fresh Next.js app and I am seeing the exact same issue with columnHelper types.

[tannerlinsley]

Working on a fix right now Tanner Linsley

…

On Jul 29, 2022, 3:55 PM -0600, Dustin Wilson ***@***.***>, wrote: We just installed the latest version with a fresh Next.js app and I am seeing the exact same issue with columnHelper types. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[ebramanti]

Is this related? #4249

[tannerlinsley]

We just shipped new types for the columnHelper along with better underlying column def types. Will you try them out and report back?

[ebramanti]

My compiler is still hanging with this type @tannerlinsley

[opti21]

Both vscode and stackblitz still show the error for me.
Updated stackblitz https://stackblitz.com/edit/github-sq9c9a?file=package.json,pages%2Findex.tsx

[tannerlinsley]

I'm definitely seeing the error in stackblitz, but can't replicate locally in the examples. Is stackblitz on the latest version of TS?

[opti21]

both local and the stackblitz is on 4.7.4 and it still shows the error.

[sjbuysse]

Same here, haven't been able to use the columnHelper since it's creation not too long ago.

[Obiwarn]

FYI: updated to v8.5.6 labeled:

Fix
type instantiation is excessively deep (#4262) (a9c4ded) by @himself65

still shows the error.

[victorkvarghese]

Same here

i tried 8.5.5 then 8.5.6. Only change i made was to convert from array of columDef to ColumHelper format

Both are throwing multiple errors.

TS2589: Type instantiation is excessively deep and possibly infinite.
and also type errors too

  TS2345: Argument of type '{ id: string; size: number; header: ({ header }: { header: any; }) => Element; cell: ({ row }: { row: any; }) => Element; }' is not assignable to parameter of type 'Column<T, unknown>'.
  Type '{ id: string; size: number; header: ({ header }: { header: any; }) => Element; cell: ({ row }: { row: any; }) => Element; }' is missing the following properties from type 'CoreColumn<T, unknown>': depth, columnDef, columns, getFlatColumns, getLeafColumns

FYI: Array of columnDefs still works

[himself65]

TS2322: Type 'ColumnDef<Room, string>' is not assignable to type 'ColumnDef<Room, unknown>'.   Type '{ footer?: ColumnDefTemplate<HeaderContext<Room, string>> | undefined; cell?: ColumnDefTemplate<CellContext<Room, string>> | undefined; meta?: ColumnMeta<...> | undefined; } & ... 6 more ... & StringHeaderIdentifier' is not assignable to type 'ColumnDef<Room, unknown>'.     Type '{ footer?: ColumnDefTemplate<HeaderContext<Room, string>> | undefined; cell?: ColumnDefTemplate<CellContext<Room, string>> | undefined; meta?: ColumnMeta<...> | undefined; } & ... 6 more ... & StringHeaderIdentifier' is not assignable to type '{ footer?: ColumnDefTemplate<HeaderContext<Room, unknown>> | undefined; cell?: ColumnDefTemplate<CellContext<Room, unknown>> | undefined; meta?: ColumnMeta<...> | undefined; } & ... 7 more ... & { ...; }'.       Type '{ footer?: ColumnDefTemplate<HeaderContext<Room, string>> | undefined; cell?: ColumnDefTemplate<CellContext<Room, string>> | undefined; meta?: ColumnMeta<...> | undefined; } & ... 6 more ... & StringHeaderIdentifier' is not assignable to type '{ footer?: ColumnDefTemplate<HeaderContext<Room, unknown>> | undefined; cell?: ColumnDefTemplate<CellContext<Room, unknown>> | undefined; meta?: ColumnMeta<...> | undefined; }'.         Types of property 'footer' are incompatible.           Type 'ColumnDefTemplate<HeaderContext<Room, string>> | undefined' is not assignable to type 'ColumnDefTemplate<HeaderContext<Room, unknown>> | undefined'.             Type '(props: HeaderContext<Room, string>) => any' is not assignable to type 'ColumnDefTemplate<HeaderContext<Room, unknown>> | undefined'.               Type '(props: HeaderContext<Room, string>) => any' is not assignable to type '(props: HeaderContext<Room, unknown>) => any'.                 Types of parameters 'props' and 'props' are incompatible.                   Type 'HeaderContext<Room, unknown>' is not assignable to type 'HeaderContext<Room, string>'.                     Types of property 'header' are incompatible.                       Type 'Header<Room, unknown>' is not assignable to type 'Header<Room, string>'.                         Type 'Header<Room, unknown>' is not assignable to type 'CoreHeader<Room, string>'.                           Types of property 'column' are incompatible.                             Type 'Column<Room, unknown>' is not assignable to type 'Column<Room, string>'.                               Type 'Column<Room, unknown>' is not assignable to type 'CoreColumn<Room, string>'.                                 Types of property 'accessorFn' are incompatible.                                   Type 'AccessorFn<Room, unknown> | undefined' is not assignable to type 'AccessorFn<Room, string> | undefined'.                                     Type 'AccessorFn<Room, unknown>' is not assignable to type 'AccessorFn<Room, string>'.                                       Type 'unknown' is not assignable to type 'string'.

[himself65]

I think one solution is change TValue from ColumnDef<TData extends RowData, TValue = unknown> to TValue = any