Skip to content

chore(eslint): remove package-level unused-vars overrides#6782

Open
Sheraff wants to merge 1 commit intomainfrom
chore/remove-unused-vars-overrides
Open

chore(eslint): remove package-level unused-vars overrides#6782
Sheraff wants to merge 1 commit intomainfrom
chore/remove-unused-vars-overrides

Conversation

@Sheraff
Copy link
Contributor

@Sheraff Sheraff commented Feb 27, 2026

Summary

  • Remove package-level unused-imports/no-unused-vars disables from router/start package ESLint configs.
  • Keep the root ESLint behavior unchanged so packages inherit the shared unused-vars policy.
  • Let CI surface any package-specific follow-up needed instead of maintaining broad local opt-outs.

Summary by CodeRabbit

  • Chores
    • Updated code quality enforcement configurations across multiple packages to ensure consistent development standards.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d958ef1 and 150f59c.

📒 Files selected for processing (8)
  • packages/router-core/eslint.config.js
  • packages/router-ssr-query-core/eslint.config.js
  • packages/solid-router/eslint.config.ts
  • packages/vue-router-ssr-query/eslint.config.ts
  • packages/vue-router/eslint.config.ts
  • packages/vue-start-client/eslint.config.ts
  • packages/vue-start-server/eslint.config.ts
  • packages/vue-start/eslint.config.ts
💤 Files with no reviewable changes (8)
  • packages/vue-router/eslint.config.ts
  • packages/router-ssr-query-core/eslint.config.js
  • packages/vue-start-server/eslint.config.ts
  • packages/vue-start-client/eslint.config.ts
  • packages/solid-router/eslint.config.ts
  • packages/vue-start/eslint.config.ts
  • packages/router-core/eslint.config.js
  • packages/vue-router-ssr-query/eslint.config.ts

📝 Walkthrough

Walkthrough

Removed the 'unused-imports/no-unused-vars': 'off' ESLint rule override from 8 ESLint configuration files across multiple packages, allowing the rule behavior to be governed by root or default configuration instead of being explicitly disabled locally.

Changes

Cohort / File(s) Summary
ESLint Configuration Updates
packages/router-core/eslint.config.js, packages/router-ssr-query-core/eslint.config.js, packages/solid-router/eslint.config.ts, packages/vue-router-ssr-query/eslint.config.ts, packages/vue-router/eslint.config.ts, packages/vue-start-client/eslint.config.ts, packages/vue-start-server/eslint.config.ts, packages/vue-start/eslint.config.ts
Removed the 'unused-imports/no-unused-vars': 'off' rule override from ESLint configurations across all packages, allowing the rule to follow root or default behavior.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

package: router-core, package: router-ssr-query-core, package: solid-router, package: vue-router

Poem

🐰 Hop, hop, the linters are freed!
No silent imports, no need to mislead,
Eight configs unified, consistent and neat,
Unused-vars rule now dances to the beat. 🎵

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removing package-level unused-vars ESLint rule overrides across multiple configuration files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/remove-unused-vars-overrides

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link

nx-cloud bot commented Feb 27, 2026

View your CI Pipeline Execution ↗ for commit 150f59c

Command Status Duration Result
nx run tanstack-router-e2e-bundle-size:build --... ✅ Succeeded 1m 32s View ↗

☁️ Nx Cloud last updated this comment at 2026-02-27 20:17:18 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 27, 2026

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@6782

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@6782

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@6782

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@6782

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@6782

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@6782

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@6782

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@6782

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@6782

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@6782

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@6782

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@6782

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@6782

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@6782

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@6782

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@6782

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@6782

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@6782

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@6782

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@6782

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@6782

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@6782

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@6782

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@6782

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@6782

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@6782

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@6782

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@6782

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@6782

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@6782

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@6782

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@6782

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@6782

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@6782

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@6782

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@6782

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@6782

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@6782

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@6782

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@6782

commit: 8ed4496

@github-actions
Copy link

Bundle Size Benchmarks

  • Commit: d958ef18d84e
  • Measured at: 2026-02-27T20:08:43.628Z
  • Baseline source: history:d958ef18d84e
  • Dashboard: bundle-size history
Scenario Current (gzip) Delta vs baseline Raw Brotli Trend
react-router.minimal 86.57 KiB 0 B (0.00%) 272.38 KiB 75.30 KiB ▁▁▂▂▂▃▃▃▃██
react-router.full 89.60 KiB 0 B (0.00%) 282.71 KiB 77.92 KiB ▂▂▁▁▁▂▂▂▂██
solid-router.minimal 35.87 KiB 0 B (0.00%) 107.49 KiB 32.26 KiB ▁▁▂▂▂▆▆▆▆██
solid-router.full 40.20 KiB 0 B (0.00%) 120.54 KiB 36.11 KiB ▁▁▃▃▃▆▆▆▆██
vue-router.minimal 51.74 KiB 0 B (0.00%) 147.46 KiB 46.49 KiB ▁▁▂▂▂▆▆▆▆██
vue-router.full 56.53 KiB 0 B (0.00%) 163.05 KiB 50.80 KiB ▁▁▂▂▂▆▆▆▆██
react-start.minimal 99.10 KiB 0 B (0.00%) 311.51 KiB 85.70 KiB ▁▁▂▂▂▃▃▃▃██
react-start.full 102.47 KiB 0 B (0.00%) 321.29 KiB 88.61 KiB ▁▁▂▂▂▂▂▂▂██
solid-start.minimal 48.18 KiB 0 B (0.00%) 145.06 KiB 42.59 KiB ▁▁▃▃▃▆▆▆▆██
solid-start.full 53.66 KiB 0 B (0.00%) 160.97 KiB 47.34 KiB ▁▁▂▂▂▅▅▅▅██

Trend sparkline is historical gzip bytes ending with this PR measurement; lower is better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant