Dependency: Update unplugin dependency version to 2.3.11 at minimum#6522
Open
ed-watts-87 wants to merge 1 commit intoTanStack:mainfrom
Open
Dependency: Update unplugin dependency version to 2.3.11 at minimum#6522ed-watts-87 wants to merge 1 commit intoTanStack:mainfrom
ed-watts-87 wants to merge 1 commit intoTanStack:mainfrom
Conversation
I've found that when bumping tanstack router plugin in our project, that unplugin is not updated along with it, this results in build errors like this:
```
file:///path/to/node_modules/unplugin/dist/rspack/loaders/transform.js:11
const res = await plugin.transform.call(Object.assign({}, this._compilation && createBuildContext(this._compiler, this._compilation, this), context), source, id);
^
TypeError: plugin.transform.call is not a function
at Object.transform (file:///path/to/node_modules//node_modules/unplugin/dist/rspack/loaders/transform.js:11:37)
at LOADER_EXECUTION (/path/to/node_modules/@rspack/core/dist/index.js:5520:18)
at runSyncOrAsync2 (/path/to/node_modules/@rspack/core/dist/index.js:5521:6)
at node:internal/util:495:21
at new Promise (<anonymous>)
at runSyncOrAsync2 (node:internal/util:481:12)
at isomorphoicRun (/path/to/node_modules/@rspack/core/dist/index.js:6309:23)
at runLoaders (/path/to/node_modules/@rspack/core/dist/index.js:6365:56)
```
Updating to 2.3.11 resolves these build errors as the implementation in the RSPack handler has changed somewhere along the way.
Contributor
📝 WalkthroughWalkthroughA dependency version update for the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've found that when bumping tanstack router plugin in our project, that unplugin is not updated along with it, this results in build errors like this:
Updating to 2.3.11 resolves these build errors as the implementation in the RSPack handler has changed somewhere along the way.
Old transform:
New transform:
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.