-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
refactor(router-core): decodePath fast path when no encoded chars #6504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
View your CI Pipeline Execution ↗ for commit e30a1fb
☁️ Nx Cloud last updated this comment at |
📝 WalkthroughWalkthroughAdds an early-exit fast path optimization to Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Comment |
Most paths do not contain encoded paths and are just alphanumeric and
-_/. We can optimizedecodePathto return early in that case.In our simple benchmark, this is a 3x improvement on the total time of
decodePathfrom 156ms to 47ms (in a 30s run)before

after

Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.