-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
docs(solid-router): port remaining basic examples #5836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughFour new Solid.js example projects are added to demonstrate TanStack Router functionality: a basic example with search parameters, an SSR file-based example with server rendering, a virtual file-based routing example, and a virtual inside-file-based example with nested virtual routes. Configuration documentation is updated with two new entries. Changes
Sequence Diagram(s)sequenceDiagram
participant Browser
participant SSR Server
participant Vite DevServer
participant File System
Note over Browser,File System: SSR Build Flow (basic-ssr-file-based)
Browser->>SSR Server: Request /posts
SSR Server->>SSR Server: Check NODE_ENV
alt Development Mode
SSR Server->>Vite DevServer: Initialize middleware
Vite DevServer->>File System: Load entry-server.tsx
Vite DevServer->>SSR Server: Provide module
else Production Mode
SSR Server->>File System: Load prebuilt entry-server.js
end
SSR Server->>SSR Server: Convert Express req to fetch Request
SSR Server->>SSR Server: Create SSR Router context (with head)
SSR Server->>SSR Server: renderRouterToString()
SSR Server->>SSR Server: Transform HTML (inject head, scripts)
SSR Server-->>Browser: Stream HTML response
Note over Browser: Client Hydration
Browser->>Browser: Load HTML
Browser->>Browser: Execute entry-client.tsx
Browser->>Browser: hydrate() + RouterClient
Browser->>Browser: Attach event listeners
Browser->>Browser: Full interactivity
Estimated code review effort🎯 4 (Complex) | ⏱️ ~50 minutes
Areas requiring extra attention:
Possibly related PRs
Suggested reviewers
Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (81)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 204ab0f
☁️ Nx Cloud last updated this comment at |
Porting
Tracking at
Summary by CodeRabbit
Documentation
New Features