Skip to content

Fix typo in Vite installation guide #5678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix typo in Vite installation guide #5678

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/router/framework/react/installation/with-vite.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ You can use those settings either at a user level or only for a single workspace

## Configuration

When using the TanStack Router Plugin with Vite for File-based routing, it comes with some sane defaults that should work for most projects:
When using the TanStack Router Plugin with Vite for File-based routing, it comes with some same defaults that should work for most projects:
Copy link
Contributor

@coderabbitai coderabbitai bot Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

Revert "same defaults" to "sane defaults"—this introduces a semantic error.

The phrase "same defaults" is grammatically and semantically incorrect. The intended phrase is "sane defaults" (meaning sensible, reasonable defaults). This change appears to have reversed the intended fix or introduced an error.

Apply this diff to correct the text:

-When using the TanStack Router Plugin with Vite for File-based routing, it comes with some same defaults that should work for most projects:
+When using the TanStack Router Plugin with Vite for File-based routing, it comes with some sane defaults that should work for most projects:

Per the AI summary, there are two instances of this change. Please verify all affected lines in the document:

🏁 Script executed:

#!/bin/bash
# Search for all instances of "same defaults" to verify scope of incorrect change
rg -n 'same defaults' docs/router/framework/react/installation/with-vite.md

Length of output: 143

🏁 Script executed:

#!/bin/bash
# Search for both "sane defaults" and broader context to understand full scope
echo "=== Searching for 'sane defaults' (correct phrase) ==="
rg -n 'sane defaults' docs/router/framework/react/installation/with-vite.md

echo -e "\n=== Searching for lines with 'defaults' keyword ==="
rg -n 'defaults' docs/router/framework/react/installation/with-vite.md

echo -e "\n=== Checking context around line 77 ==="
rg -n -B2 -A2 'same defaults' docs/router/framework/react/installation/with-vite.md

Length of output: 710

Revert "same defaults" to "sane defaults" on line 77—this introduces a semantic error.

The phrase "same defaults" is semantically incorrect. The intended phrase is "sane defaults" (meaning sensible, reasonable defaults). The file currently contains this error at line 77 only.

Apply this diff:

-When using the TanStack Router Plugin with Vite for File-based routing, it comes with some same defaults that should work for most projects:
+When using the TanStack Router Plugin with Vite for File-based routing, it comes with some sane defaults that should work for most projects:
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
When using the TanStack Router Plugin with Vite for File-based routing, it comes with some same defaults that should work for most projects:
When using the TanStack Router Plugin with Vite for File-based routing, it comes with some sane defaults that should work for most projects:
🤖 Prompt for AI Agents 
In docs/router/framework/react/installation/with-vite.md around line 77, the
phrase "same defaults" is incorrect; replace it with "sane defaults" so the
sentence reads that the TanStack Router Plugin comes with "sane defaults" that
should work for most projects. Make the single-word change on that line and save
the file.


```json
{
Expand Down