-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
docs: Add comparison page back #5503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughAdds a new React framework comparison doc and updates site navigation; removes redundant comparison commentary from React and Solid overview pages. All changes are documentation-only. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (1)docs/{router,start}/**📄 CodeRabbit inference engine (AGENTS.md)
Files:
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit e405b14
☁️ Nx Cloud last updated this comment at |
More templates
@tanstack/arktype-adapter
@tanstack/directive-functions-plugin
@tanstack/eslint-plugin-router
@tanstack/history
@tanstack/nitro-v2-vite-plugin
@tanstack/react-router
@tanstack/react-router-devtools
@tanstack/react-router-ssr-query
@tanstack/react-start
@tanstack/react-start-client
@tanstack/react-start-server
@tanstack/router-cli
@tanstack/router-core
@tanstack/router-devtools
@tanstack/router-devtools-core
@tanstack/router-generator
@tanstack/router-plugin
@tanstack/router-ssr-query-core
@tanstack/router-utils
@tanstack/router-vite-plugin
@tanstack/server-functions-plugin
@tanstack/solid-router
@tanstack/solid-router-devtools
@tanstack/solid-start
@tanstack/solid-start-client
@tanstack/solid-start-server
@tanstack/start-client-core
@tanstack/start-plugin-core
@tanstack/start-server-core
@tanstack/start-static-server-functions
@tanstack/start-storage-context
@tanstack/valibot-adapter
@tanstack/virtual-file-routes
@tanstack/zod-adapter
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Nitpick comments (1)
docs/router/framework/react/comparison.md (1)
12-19: Enhance the feature key formatting for clarity.The feature key is useful, but the list items could be formatted more clearly with markdown list syntax for better readability and consistency with the rest of the documentation. Consider using proper list formatting:
-Feature/Capability Key: - -- ✅ 1st-class, built-in, and ready to use with no added configuration or code -- 🟡 Partial Support (on a scale of 5) -- 🟠 Supported via addon/community package -- 🔶 Possible, but requires custom code/implementation/casting -- 🛑 Not officially supported +## Feature/Capability Key + +- **✅** 1st-class, built-in, and ready to use with no added configuration or code +- **🟡** Partial Support (on a scale of 5) +- **🟠** Supported via addon/community package +- **🔶** Possible, but requires custom code/implementation/casting +- **🛑** Not officially supported
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
docs/router/framework/react/comparison.md(1 hunks)docs/router/framework/react/overview.md(0 hunks)docs/router/framework/solid/overview.md(0 hunks)
💤 Files with no reviewable changes (2)
- docs/router/framework/react/overview.md
- docs/router/framework/solid/overview.md
🧰 Additional context used
📓 Path-based instructions (2)
docs/**/*.{md,mdx}
📄 CodeRabbit inference engine (AGENTS.md)
Use internal docs links relative to the docs/ folder (e.g., ./guide/data-loading)
Files:
docs/router/framework/react/comparison.md
docs/{router,start}/**
📄 CodeRabbit inference engine (AGENTS.md)
Place router docs under docs/router/ and start framework docs under docs/start/
Files:
docs/router/framework/react/comparison.md
🪛 LanguageTool
docs/router/framework/react/comparison.md
[grammar] ~14-~14: There might be a mistake here.
Context: ... use with no added configuration or code - 🟡 Partial Support (on a scale of 5) - ?...
(QB_NEW_EN)
[grammar] ~15-~15: There might be a mistake here.
Context: ...e - 🟡 Partial Support (on a scale of 5) - 🟠 Supported via addon/community package...
(QB_NEW_EN)
[grammar] ~16-~16: There might be a mistake here.
Context: ...🟠 Supported via addon/community package - 🔶 Possible, but requires custom code/im...
(QB_NEW_EN)
[grammar] ~17-~17: There might be a mistake here.
Context: ...uires custom code/implementation/casting - 🛑 Not officially supported | ...
(QB_NEW_EN)
[grammar] ~18-~18: There might be a mistake here.
Context: ...on/casting - 🛑 Not officially supported | ...
(QB_NEW_EN)
[uncategorized] ~22-~22: The official name of this software platform is spelled with a capital “H”.
Context: ...----------------------------------- | | Github Repo / Stars ...
(GITHUB)
🪛 markdownlint-cli2 (0.18.1)
docs/router/framework/react/comparison.md
22-22: Images should have alternate text (alt text)
(MD045, no-alt-text)
22-22: Images should have alternate text (alt text)
(MD045, no-alt-text)
22-22: Images should have alternate text (alt text)
(MD045, no-alt-text)
23-23: Images should have alternate text (alt text)
(MD045, no-alt-text)
23-23: Images should have alternate text (alt text)
(MD045, no-alt-text)
84-84: Link and image reference definitions should be needed
Unused link or image reference definition: "_"
(MD053, link-image-reference-definitions)
90-90: Link and image reference definitions should be needed
Unused link or image reference definition: "bpl-history"
(MD053, link-image-reference-definitions)
91-91: Link and image reference definitions should be needed
Duplicate link or image reference definition: "_"
(MD053, link-image-reference-definitions)
93-93: Link and image reference definitions should be needed
Unused link or image reference definition: "bp-nextjs"
(MD053, link-image-reference-definitions)
96-96: Link and image reference definitions should be needed
Unused link or image reference definition: "bpl-nextjs"
(MD053, link-image-reference-definitions)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Preview
🔇 Additional comments (2)
docs/router/framework/react/comparison.md (2)
1-10: Frontmatter and introduction look good.The frontmatter is properly formatted, and the introductory text clearly explains the purpose and limitations of the comparison while inviting contributions.
20-79: Comparison table is comprehensive and well-structured.The table effectively compares capabilities across the three frameworks with clear visual indicators. The breadth of features covered (routing, type safety, full-stack capabilities, etc.) provides useful context for developers evaluating options.
|
|
||
| | | TanStack Router / Start | React Router DOM [_(Website)_][router] | Next.JS [_(Website)_][nextjs] | | ||
| | ---------------------------------------------- | ------------------------------------------------ | ----------------------------------------------------- | ----------------------------------------------------- | | ||
| | Github Repo / Stars | [![][stars-tanstack-router]][gh-tanstack-router] | [![][stars-router]][gh-router] | [![][stars-nextjs]][gh-nextjs] | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix capitalization: "Github" → "GitHub".
The table header uses "Github" but the official branding is "GitHub".
-| Github Repo / Stars | [![][stars-tanstack-router]][gh-tanstack-router] | [![][stars-router]][gh-router] | [![][stars-nextjs]][gh-nextjs] |
+| GitHub Repo / Stars | [![][stars-tanstack-router]][gh-tanstack-router] | [![][stars-router]][gh-router] | [![][stars-nextjs]][gh-nextjs] |📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| | Github Repo / Stars | [![][stars-tanstack-router]][gh-tanstack-router] | [![][stars-router]][gh-router] | [![][stars-nextjs]][gh-nextjs] | | |
| | GitHub Repo / Stars | [![][stars-tanstack-router]][gh-tanstack-router] | [![][stars-router]][gh-router] | [![][stars-nextjs]][gh-nextjs] | |
🧰 Tools
🪛 LanguageTool
[uncategorized] ~22-~22: The official name of this software platform is spelled with a capital “H”.
Context: ...----------------------------------- | | Github Repo / Stars ...
(GITHUB)
🪛 markdownlint-cli2 (0.18.1)
22-22: Images should have alternate text (alt text)
(MD045, no-alt-text)
22-22: Images should have alternate text (alt text)
(MD045, no-alt-text)
22-22: Images should have alternate text (alt text)
(MD045, no-alt-text)
🤖 Prompt for AI Agents
In docs/router/framework/react/comparison.md around line 22, the table header
uses incorrect capitalization "Github" — change it to the official branding
"GitHub" by replacing "Github" with "GitHub" in that header cell so the
documentation follows correct product naming.
| [bp-tanstack-router]: https://badgen.net/bundlephobia/minzip/@tanstack/react-router | ||
| [bpl-tanstack-router]: https://bundlephobia.com/result?p=@tanstack/react-router | ||
| [gh-tanstack-router]: https://github.com/tanstack/router | ||
| [stars-tanstack-router]: https://img.shields.io/github/stars/tanstack/router?label=%F0%9F%8C%9F | ||
| [_]: _ | ||
| [router]: https://github.com/remix-run/react-router | ||
| [bp-router]: https://badgen.net/bundlephobia/minzip/react-router | ||
| [gh-router]: https://github.com/remix-run/react-router | ||
| [stars-router]: https://img.shields.io/github/stars/remix-run/react-router?label=%F0%9F%8C%9F | ||
| [bpl-router]: https://bundlephobia.com/result?p=react-router | ||
| [bpl-history]: https://bundlephobia.com/result?p=history | ||
| [_]: _ | ||
| [nextjs]: https://nextjs.org/docs/routing/introduction | ||
| [bp-nextjs]: https://badgen.net/bundlephobia/minzip/next.js?label=All | ||
| [gh-nextjs]: https://github.com/vercel/next.js | ||
| [stars-nextjs]: https://img.shields.io/github/stars/vercel/next.js?label=%F0%9F%8C%9F | ||
| [bpl-nextjs]: https://bundlephobia.com/result?p=next |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove unused reference definitions.
Several reference link definitions are defined but never used in the document. Remove the unused entries to clean up the file:
[bp-tanstack-router]: https://badgen.net/bundlephobia/minzip/@tanstack/react-router
[bpl-tanstack-router]: https://bundlephobia.com/result?p=@tanstack/react-router
[gh-tanstack-router]: https://github.com/tanstack/router
[stars-tanstack-router]: https://img.shields.io/github/stars/tanstack/router?label=%F0%9F%8C%9F
-[_]: _
[router]: https://github.com/remix-run/react-router
[bp-router]: https://badgen.net/bundlephobia/minzip/react-router
[gh-router]: https://github.com/remix-run/react-router
[stars-router]: https://img.shields.io/github/stars/remix-run/react-router?label=%F0%9F%8C%9F
[bpl-router]: https://bundlephobia.com/result?p=react-router
-[bpl-history]: https://bundlephobia.com/result?p=history
-[_]: _
[nextjs]: https://nextjs.org/docs/routing/introduction
-[bp-nextjs]: https://badgen.net/bundlephobia/minzip/next.js?label=All
[gh-nextjs]: https://github.com/vercel/next.js
[stars-nextjs]: https://img.shields.io/github/stars/vercel/next.js?label=%F0%9F%8C%9F
-[bpl-nextjs]: https://bundlephobia.com/result?p=next🧰 Tools
🪛 markdownlint-cli2 (0.18.1)
84-84: Link and image reference definitions should be needed
Unused link or image reference definition: "_"
(MD053, link-image-reference-definitions)
90-90: Link and image reference definitions should be needed
Unused link or image reference definition: "bpl-history"
(MD053, link-image-reference-definitions)
91-91: Link and image reference definitions should be needed
Duplicate link or image reference definition: "_"
(MD053, link-image-reference-definitions)
93-93: Link and image reference definitions should be needed
Unused link or image reference definition: "bp-nextjs"
(MD053, link-image-reference-definitions)
96-96: Link and image reference definitions should be needed
Unused link or image reference definition: "bpl-nextjs"
(MD053, link-image-reference-definitions)
🤖 Prompt for AI Agents
In docs/router/framework/react/comparison.md around lines 80 to 96, several
markdown reference link definitions (e.g., bp-tanstack-router,
bpl-tanstack-router, gh-tanstack-router, stars-tanstack-router, _, router,
bp-router, gh-router, stars-router, bpl-router, bpl-history, nextjs, bp-nextjs,
gh-nextjs, stars-nextjs, bpl-nextjs) are declared but not referenced anywhere in
the document; remove the unused reference definitions and leave only the
reference links that are actually referenced elsewhere in the file (or
consolidate duplicates like repeated [_] entries), ensuring the remaining
references are correct and the file still builds.
Summary by CodeRabbit