-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Docs(Router-SSR): Resolve typos #5425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughDocumentation for React Router SSR updated to replace defaultRenderToString with defaultRenderHandler in imports and examples, along with minor wording adjustments (“less priority” → “lower priority”). No functional logic changes beyond reflecting the new public API name in server-side usage examples. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant Server
participant SSR Module as @tanstack/react-router/ssr/server
participant Router
User->>Server: HTTP request
Server->>SSR Module: defaultRenderHandler(request, router)
SSR Module->>Router: Resolve route, load data
Router-->>SSR Module: Rendered stream/markup
SSR Module-->>Server: Response payload
Server-->>User: HTML/streamed response
note over SSR Module,Server: defaultRenderHandler replaces defaultRenderToString
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (2)docs/**/*.{md,mdx}📄 CodeRabbit inference engine (AGENTS.md)
Files:
docs/{router,start}/**📄 CodeRabbit inference engine (AGENTS.md)
Files:
Comment |
View your CI Pipeline Execution ↗ for commit aad4e61
☁️ Nx Cloud last updated this comment at |
More templates
@tanstack/arktype-adapter
@tanstack/directive-functions-plugin
@tanstack/eslint-plugin-router
@tanstack/history
@tanstack/nitro-v2-vite-plugin
@tanstack/react-router
@tanstack/react-router-devtools
@tanstack/react-router-ssr-query
@tanstack/react-start
@tanstack/react-start-client
@tanstack/react-start-server
@tanstack/router-cli
@tanstack/router-core
@tanstack/router-devtools
@tanstack/router-devtools-core
@tanstack/router-generator
@tanstack/router-plugin
@tanstack/router-ssr-query-core
@tanstack/router-utils
@tanstack/router-vite-plugin
@tanstack/server-functions-plugin
@tanstack/solid-router
@tanstack/solid-router-devtools
@tanstack/solid-start
@tanstack/solid-start-client
@tanstack/solid-start-server
@tanstack/start-client-core
@tanstack/start-plugin-core
@tanstack/start-server-core
@tanstack/start-static-server-functions
@tanstack/start-storage-context
@tanstack/valibot-adapter
@tanstack/virtual-file-routes
@tanstack/zod-adapter
commit: |
resolve typos
resolve typos
There are a few typos in the SSR documentation that is being addressed.
Summary by CodeRabbit