fix typos and wrong paths in server-routes.md #4461
+17
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit e726c37.
☁️ Nx Cloud last updated this comment at |
AhmedBaset
commented
Jun 18, 2025
| @@ -26,7 +26,7 @@ export const ServerRoute = createServerFileRoute().methods({ | |||
| Because server routes can be defined in the same directory as your app routes, you can even use the same file for both! | |||
|
|
|||
| ```tsx | |||
| // routes/hello.tsx | |||
| // routes/api/hello.tsx | |||
There was a problem hiding this comment.
To match
While both routes/hello.tsx and routes/api/hello.tsx are supported now, api/hello makes more sense api routes
There was a problem hiding this comment.
not really, this example explicitly shows how to colocate with render routes
There was a problem hiding this comment.
The server route is at routes/hello.tsx (/hello) and the fetch request goes to /api/hello One of them must change
More templates
@tanstack/arktype-adapter
@tanstack/directive-functions-plugin
@tanstack/eslint-plugin-router
@tanstack/history
@tanstack/react-router
@tanstack/react-router-devtools
@tanstack/react-router-with-query
@tanstack/react-start
@tanstack/react-start-client
@tanstack/react-start-plugin
@tanstack/react-start-server
@tanstack/router-cli
@tanstack/router-core
@tanstack/router-devtools
@tanstack/router-devtools-core
@tanstack/router-generator
@tanstack/router-plugin
@tanstack/router-utils
@tanstack/router-vite-plugin
@tanstack/server-functions-plugin
@tanstack/solid-router
@tanstack/solid-router-devtools
@tanstack/solid-start
@tanstack/solid-start-client
@tanstack/solid-start-plugin
@tanstack/solid-start-server
@tanstack/start-client-core
@tanstack/start-plugin-core
@tanstack/start-server-core
@tanstack/start-server-functions-client
@tanstack/start-server-functions-fetcher
@tanstack/start-server-functions-server
@tanstack/valibot-adapter
@tanstack/virtual-file-routes
@tanstack/zod-adapter
commit: |
AhmedBaset
commented
Jun 18, 2025
|
|
||
| ```ts | ||
| // routes/users/$id.ts | ||
| // routes/api/users/$id.ts |
There was a problem hiding this comment.
schiller-manuel
requested changes
Jun 19, 2025
I know, but there is a At the end of every example. One of the file name or the comment needs to be fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.