Skip to content

fix: only re-execute beforeLoad if previous run failed #4433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
schiller-manuel merged 2 commits into from
Jun 15, 2025
Merged

fix: only re-execute beforeLoad if previous run failed #4433

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b103eb
fix: only re-execute beforeLoad if previous run failed
schiller-manuel Jun 15, 2025
6fc35e2
ci: apply automated fixes
autofix-ci[bot] Jun 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/router-core/src/router.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2182,7 +2182,7 @@ export class RouterCore<

// Wait for the beforeLoad to resolve before we continue
await existingMatch.beforeLoadPromise
executeBeforeLoad = this.getMatch(matchId)!.status !== 'success'
executeBeforeLoad = this.getMatch(matchId)!.status === 'error'
}
if (executeBeforeLoad) {
// If we are not in the middle of a load OR the previous load failed, start it
Expand Down
Loading