Skip to content

Update build-from-scratch.md - Fix typo in charset meta #3390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

lb-
Copy link

@lb- lb- commented Feb 11, 2025

@github-actions github-actions bot added the documentation Everything documentation related label Feb 11, 2025
Copy link

nx-cloud bot commented Feb 12, 2025

View your CI Pipeline Execution ↗ for commit 73c84a2.

Command Status Duration Result
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 56s View ↗
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-12 02:32:43 UTC

Copy link

pkg-pr-new bot commented Feb 12, 2025

Open in Stackblitz

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@3390

@tanstack/create-router

npm i https://pkg.pr.new/@tanstack/create-router@3390

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/@tanstack/directive-functions-plugin@3390

@tanstack/create-start

npm i https://pkg.pr.new/@tanstack/create-start@3390

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@3390

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@3390

@tanstack/react-cross-context

npm i https://pkg.pr.new/@tanstack/react-cross-context@3390

@tanstack/react-router-with-query

npm i https://pkg.pr.new/@tanstack/react-router-with-query@3390

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@3390

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@3390

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@3390

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@3390

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@3390

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@3390

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@3390

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@3390

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/@tanstack/server-functions-plugin@3390

@tanstack/start

npm i https://pkg.pr.new/@tanstack/start@3390

@tanstack/start-api-routes

npm i https://pkg.pr.new/@tanstack/start-api-routes@3390

@tanstack/start-client

npm i https://pkg.pr.new/@tanstack/start-client@3390

@tanstack/start-config

npm i https://pkg.pr.new/@tanstack/start-config@3390

@tanstack/start-plugin

npm i https://pkg.pr.new/@tanstack/start-plugin@3390

@tanstack/start-router-manifest

npm i https://pkg.pr.new/@tanstack/start-router-manifest@3390

@tanstack/start-server

npm i https://pkg.pr.new/@tanstack/start-server@3390

@tanstack/start-server-functions-client

npm i https://pkg.pr.new/@tanstack/start-server-functions-client@3390

@tanstack/start-server-functions-fetcher

npm i https://pkg.pr.new/@tanstack/start-server-functions-fetcher@3390

@tanstack/start-server-functions-handler

npm i https://pkg.pr.new/@tanstack/start-server-functions-handler@3390

@tanstack/start-server-functions-server

npm i https://pkg.pr.new/@tanstack/start-server-functions-server@3390

@tanstack/start-server-functions-ssr

npm i https://pkg.pr.new/@tanstack/start-server-functions-ssr@3390

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@3390

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@3390

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@3390

commit: 73c84a2

Copy link
Member

@SeanCassiere SeanCassiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking this using "request changes" due to the following:

This change would cause a typescript error. Since it wouldn't match the types, as the RouteMatch interface expects the following:

interface RouteMatch {
	// ...
	meta?: Array<React.JSX.IntrinsicElements['meta'] | undefined>
	// ...
}

@lb-
Copy link
Author

lb- commented Feb 12, 2025

OK looks like this value should be charSet when declared with React, however, React SSR will not convert it to lower case.

See

As HTML attribute names are case insensitive, the React team have decided to not convert this (See PR above).

https://html.spec.whatwg.org/multipage/semantics.html#character-encoding-declaration

Although it feels inconsistent it's nothing to do with TanStack, just a quirk of React DOM generation when pre-rendering HTML.

@lb- lb- closed this Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Everything documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants