-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Update build-from-scratch.md - Fix typo in charset meta #3390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
View your CI Pipeline Execution ↗ for commit 73c84a2.
☁️ Nx Cloud last updated this comment at |
More templates
@tanstack/arktype-adapter
@tanstack/create-router
@tanstack/directive-functions-plugin
@tanstack/create-start
@tanstack/eslint-plugin-router
@tanstack/history
@tanstack/react-cross-context
@tanstack/react-router-with-query
@tanstack/react-router
@tanstack/router-cli
@tanstack/router-core
@tanstack/router-devtools
@tanstack/router-generator
@tanstack/router-plugin
@tanstack/router-utils
@tanstack/router-vite-plugin
@tanstack/server-functions-plugin
@tanstack/start
@tanstack/start-api-routes
@tanstack/start-client
@tanstack/start-config
@tanstack/start-plugin
@tanstack/start-router-manifest
@tanstack/start-server
@tanstack/start-server-functions-client
@tanstack/start-server-functions-fetcher
@tanstack/start-server-functions-handler
@tanstack/start-server-functions-server
@tanstack/start-server-functions-ssr
@tanstack/valibot-adapter
@tanstack/virtual-file-routes
@tanstack/zod-adapter
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking this using "request changes" due to the following:
This change would cause a typescript error. Since it wouldn't match the types, as the RouteMatch
interface expects the following:
interface RouteMatch {
// ...
meta?: Array<React.JSX.IntrinsicElements['meta'] | undefined>
// ...
}
OK looks like this value should be See
As HTML attribute names are case insensitive, the React team have decided to not convert this (See PR above). https://html.spec.whatwg.org/multipage/semantics.html#character-encoding-declaration Although it feels inconsistent it's nothing to do with TanStack, just a quirk of React DOM generation when pre-rendering HTML. |
I believe this should be
charset
notcharSet
.Build output when following the documentation.
