-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
changes to the route context branch #2141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit de3997d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
tannerlinsley
added a commit
that referenced
this pull request
Aug 20, 2024
* feat(react-router): add types for routeContext * perf(react-router): optimise new types for `routeContext` * chore(react-router): add type tests for routeContext and beforeLoad * checkpoint * ci: apply automated fixes * updates docs * fix: tests * fix: context * chore: fix the lockfile * ci: apply automated fixes * style(react-router): fixup the eslint errors * fix: hydration mismatch during SSR, refactor matchRoutes to take location * fix: serialize beforeLoadContext during SSR * examples: add start-basic-auth * fix: history export parseHref * feat: routeOptions.preload to allow disabling route-level preloading * fix: full support for href redirects * feat: useServerFn hook to allow handling server side effects like redirects outside of router lifecycles * fix: server redirect and notFound now default to 200 status code for runtime to handle * fix: update pnpm * ci: apply automated fixes * examples: fix start-basic-auth * tests: fix playwright * tests: fix playwright * tests: fix playwright * sean's changes to the route context branch (#2141) * chore: type the objects used for `routeContext` and `beforeLoad` * refactor: move the defaultTransformer from start to react-router * test: add tests to the defaultTransformer * test(react-router): add runtime unit tests for the `context` function * examples: init start-clerk-basic * fix: lockfile * ci: apply automated fixes * test: remove failing test for WIP clerk example * tests: fix more clerk wip tests * fix: lockfile * tests: more clerk fixes * tests: skip WIP clerk example --------- Co-authored-by: Tanner Linsley <tannerlinsley@gmail.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: SeanCassiere <33615041+SeanCassiere@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.