-
-
Couldn't load subscription status.
- Fork 1.3k
feat(router-devtools): add shadowDOMTarget option to TanStackRouterDevtools and TanStackRouterDevtoolsPanel (#1709) #1720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This needs to be checked locally to make sure there aren't any visual regressions for the existing (non ShadowDOM) users. |
|
@SeanCassiere Thanks! I will take a look at this tomorrow 😄 (Saturday) |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit d837ecb. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 5 targets
Sent with 💌 from NxCloud. |
|
@ardeora Should I show you screenshots of the devtools in a no shadow dom setup? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SeanCassiere This is looking good! I tested it out with CSR and SSR examples too and the styles are looking to hold up well!
|
@SeanCassiere Also the devtoolsPanel styles are broken in the existing implementation. I'll try to fix them in a new PR. This isn't related to the shadow dom changes 😄 |
Is this fine to go through for now? |
|
Yeah all good to go! Thanks @reihwald for working on this! |
|
Glad I could help 👍 |
Closes #1709
TanStackRouterDevtools before:
TanStackRouterDevtoolsPanel before:
TanStackRouterDevtools after:
TanStackRouterDevtoolsPanel after: