Skip to content

Conversation

@reihwald
Copy link
Contributor

@reihwald reihwald commented Jun 6, 2024

Closes #1709

TanStackRouterDevtools before:

Screenshot 2024-06-06 170017

TanStackRouterDevtoolsPanel before:

Screenshot 2024-06-06 165959

TanStackRouterDevtools after:

Screenshot 2024-06-06 163338

TanStackRouterDevtoolsPanel after:

Screenshot 2024-06-06 163356

@SeanCassiere
Copy link
Member

This needs to be checked locally to make sure there aren't any visual regressions for the existing (non ShadowDOM) users.

@SeanCassiere SeanCassiere changed the title feat: add shadowDOMTarget option to TanStackRouterDevtools and TanStackRouterDevtoolsPanel (#1709) feat(router-devtools): add shadowDOMTarget option to TanStackRouterDevtools and TanStackRouterDevtoolsPanel (#1709) Jun 8, 2024
@SeanCassiere SeanCassiere requested a review from ardeora June 8, 2024 00:57
@ardeora
Copy link
Contributor

ardeora commented Jun 8, 2024

@SeanCassiere Thanks! I will take a look at this tomorrow 😄 (Saturday)

@nx-cloud
Copy link

nx-cloud bot commented Jun 9, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit d837ecb. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 5 targets

Sent with 💌 from NxCloud.

@reihwald
Copy link
Contributor Author

reihwald commented Jun 10, 2024

@ardeora Should I show you screenshots of the devtools in a no shadow dom setup?

Copy link
Contributor

@ardeora ardeora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SeanCassiere This is looking good! I tested it out with CSR and SSR examples too and the styles are looking to hold up well!

@ardeora
Copy link
Contributor

ardeora commented Jun 11, 2024

@SeanCassiere Also the devtoolsPanel styles are broken in the existing implementation. I'll try to fix them in a new PR. This isn't related to the shadow dom changes 😄

@SeanCassiere
Copy link
Member

@SeanCassiere Also the devtoolsPanel styles are broken in the existing implementation. I'll try to fix them in a new PR. This isn't related to the shadow dom changes 😄

Is this fine to go through for now?

@ardeora
Copy link
Contributor

ardeora commented Jun 11, 2024

Yeah all good to go! Thanks @reihwald for working on this!

@SeanCassiere SeanCassiere merged commit a1fb641 into TanStack:main Jun 11, 2024
@reihwald
Copy link
Contributor Author

Glad I could help 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TanStackRouterDevtools broken when rendering inside of a shadow DOM

3 participants