-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
feat(vue-query-devtools): Embedded panel mode #9790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
π¦ Changeset detectedLatest commit: 3f4b2a7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
View your CI Pipeline Execution β for commit 3f4b2a7
βοΈ Nx Cloud last updated this comment at |
|
Caution Review failedThe pull request is closed. WalkthroughThis PR introduces embedded panel mode for Vue Query Devtools by adding a new Changes
Sequence Diagram(s)sequenceDiagram
participant Vue as Vue App
participant Panel as VueQueryDevtoolsPanel
participant Client as QueryClient
participant Mount as DOM Container
Vue->>Panel: mount with props (client?, errorTypes, style, onClose)
alt client prop provided
Panel->>Client: use props.client
else
Panel->>Panel: useQueryClient()
end
Panel->>Panel: compute containerStyle
Panel->>Panel: setErrorTypes(props.errorTypes)
Panel->>Panel: setOnClose(props.onClose)
Panel->>Mount: onMounted - render devtools panel
Mount->>Mount: append to DOM
Note over Panel: Component lifecycle active
Vue->>Panel: component unmount
Panel->>Mount: onScopeDispose - cleanup
Estimated code review effortπ― 3 (Moderate) | β±οΈ ~25 minutes The changes involve new logic across multiple files (component, types, exports, and documentation) with moderate complexity. The component implementation handles client resolution, lifecycle management, and reactive property updates. While individual pieces are straightforward, the integration across multiple modules and verification of proper devtools initialization require careful review. Possibly related PRs
Suggested reviewers
Poem
β¨ Finishing touches
π§ͺ Generate unit tests (beta)
π Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro π Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Sizes for commit 3f4b2a7:
|
π― Changes
β Checklist
pnpm run test:pr.π Release Impact
Summary by CodeRabbit
New Features
Documentation