feat(svelte-query): merge main branch and fix failed tests #9650

Oungseik · 2025-09-13T05:20:25Z

Merge the main branch into the target branch. Fix locally reference state which cause some test to fail by wrap the reference of state inside a function in createMutation.svelte.ts

feat(svelte-query): merge main branch and fix failed tests

coderabbitai · 2025-09-13T05:20:32Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

nx-cloud · 2025-09-17T16:26:05Z

View your CI Pipeline Execution ↗ for commit 2f27208

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	⏳ In Progress	...	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	2s	View ↗

☁️ Nx Cloud last updated this comment at 2025-09-26 11:35:28 UTC

pkg-pr-new · 2025-09-22T23:15:27Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9650

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9650

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9650

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9650

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9650

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9650

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9650

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9650

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9650

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9650

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9650

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9650

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9650

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9650

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9650

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9650

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9650

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9650

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9650

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9650

commit: 2f27208

changeset-bot · 2025-09-26T09:33:36Z

⚠️ No Changeset found

Latest commit: 2f27208

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

lachlancollins · 2025-09-26T09:40:26Z

@Oungseik oops I've made a mistake here and accidentally "merged" this PR. I've synced changes from main to svelte-5-adapter, and it seems like I messed up with the merge conflict resolution with your PR. Would you be able to open a new PR with just the mutation test fixes? Thanks!!

Oungseik · 2025-09-27T10:21:36Z

Yes, I can.

Oungseik · 2025-09-27T10:34:20Z

I pulled the latest changes, ran the tests and all passed. No fixes need right?

lachlancollins · 2025-09-27T12:44:52Z

I pulled the latest changes, ran the tests and all passed. No fixes need right?

Great, I assumed that there was something you were fixing independently of the merge, but if not then I guess we don't need any more changes!

Oungseik and others added 10 commits September 13, 2025 08:12

Merge branch 'main' into svelte-5-experimental

582cbda

fix: temporary disable type checking in vite.config.ts

5d5bb68

fix: restore the tests according svelte 5 adapter branch

7fd609f

fix: fix local reference warning

8c28b70

fix: fix state not update due to reference the state internally

5d63545

fix: assert isEnable to be true if the query is not disabled

531b0ff

fix: use rune

0edf284

Merge branch 'TanStack:main' into svelte-5-experimental

61ce92e

refactor(svelte-query): remove deleted tests in svelte5-adapter branch

edb30e6

Merge pull request #4 from Oungseik/svelte-5-experimental

1b1c5d8

feat(svelte-query): merge main branch and fix failed tests

github-actions bot added package: vue-query-devtools package: solid-query-devtools package: query-broadcast-client-experimental package: react-query-next-experimental labels Sep 13, 2025

Merge branch 'svelte-5-adapter' into svelte-5-adapter

2f27208

lachlancollins merged commit 2f27208 into TanStack:svelte-5-adapter Sep 26, 2025
5 of 6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat(svelte-query): merge main branch and fix failed tests #9650

feat(svelte-query): merge main branch and fix failed tests #9650

Uh oh!

Oungseik commented Sep 13, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Sep 13, 2025 •

edited

Loading

Review skipped

Uh oh!

nx-cloud bot commented Sep 17, 2025 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Sep 22, 2025 •

edited

Loading

Uh oh!

changeset-bot bot commented Sep 26, 2025

Uh oh!

Uh oh!

lachlancollins commented Sep 26, 2025

Uh oh!

Oungseik commented Sep 27, 2025

Uh oh!

Oungseik commented Sep 27, 2025

Uh oh!

lachlancollins commented Sep 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

feat(svelte-query): merge main branch and fix failed tests #9650

feat(svelte-query): merge main branch and fix failed tests #9650

Uh oh!

Conversation

Oungseik commented Sep 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Sep 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

nx-cloud bot commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new bot commented Sep 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Sep 26, 2025

⚠️ No Changeset found

Uh oh!

Uh oh!

lachlancollins commented Sep 26, 2025

Uh oh!

Oungseik commented Sep 27, 2025

Uh oh!

Oungseik commented Sep 27, 2025

Uh oh!

lachlancollins commented Sep 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Oungseik commented Sep 13, 2025 •

edited

Loading

coderabbitai bot commented Sep 13, 2025 •

edited

Loading

nx-cloud bot commented Sep 17, 2025 •

edited

Loading

pkg-pr-new bot commented Sep 22, 2025 •

edited

Loading