Skip to content

test(react-query/useMutationState): remove 'vi.waitFor' and add 'advanceTimersByTimeAsync' #9353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 5, 2025
Merged

test(react-query/useMutationState): remove 'vi.waitFor' and add 'advanceTimersByTimeAsync' #9353

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ab30a9
test(react-query/useMutationState): remove 'vi.waitFor' and add 'adva…
sukvvon Jul 3, 2025
086e892
Merge branch 'main' into test/react-query-useMutationState-add-advanc…
manudeli Jul 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 23 additions & 13 deletions packages/react-query/src/__tests__/useMutationState.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,12 +62,12 @@ describe('useIsMutating', () => {
// [ +0, 1, 2, 1, +0 ]
// our batching strategy might yield different results

await vi.waitFor(() => expect(isMutatingArray[0]).toEqual(0))
await vi.waitFor(() => expect(isMutatingArray[1]).toEqual(1))
await vi.waitFor(() => expect(isMutatingArray[2]).toEqual(2))
await vi.waitFor(() =>
expect(isMutatingArray[isMutatingArray.length - 1]).toEqual(0),
)
await vi.advanceTimersByTimeAsync(40)
expect(isMutatingArray[0]).toEqual(0)
expect(isMutatingArray[1]).toEqual(1)
expect(isMutatingArray[2]).toEqual(2)
await vi.advanceTimersByTimeAsync(1)
expect(isMutatingArray[isMutatingArray.length - 1]).toEqual(0)
})

it('should filter correctly by mutationKey', async () => {
Expand Down Expand Up @@ -99,7 +99,8 @@ describe('useIsMutating', () => {
}

renderWithClient(queryClient, <Page />)
await vi.waitFor(() => expect(isMutatingArray).toEqual([0, 1, 0]))
await vi.advanceTimersByTimeAsync(101)
expect(isMutatingArray).toEqual([0, 1, 0])
})

it('should filter correctly by predicate', async () => {
Expand Down Expand Up @@ -134,7 +135,8 @@ describe('useIsMutating', () => {
}

renderWithClient(queryClient, <Page />)
await vi.waitFor(() => expect(isMutatingArray).toEqual([0, 1, 0]))
await vi.advanceTimersByTimeAsync(101)
expect(isMutatingArray).toEqual([0, 1, 0])
})

it('should use provided custom queryClient', async () => {
Expand Down Expand Up @@ -163,13 +165,20 @@ describe('useIsMutating', () => {

const rendered = render(<Page></Page>)

await vi.waitFor(() =>
expect(rendered.getByText('mutating: 1')).toBeInTheDocument(),
)
await vi.advanceTimersByTimeAsync(0)
expect(rendered.getByText('mutating: 1')).toBeInTheDocument()
})
})

describe('useMutationState', () => {
beforeEach(() => {
vi.useFakeTimers()
})

afterEach(() => {
vi.useRealTimers()
})

it('should return variables after calling mutate', async () => {
const queryClient = new QueryClient()
const variables: Array<Array<unknown>> = []
Expand Down Expand Up @@ -211,11 +220,12 @@ describe('useMutationState', () => {

const rendered = renderWithClient(queryClient, <Page />)

await vi.waitFor(() => rendered.getByText('data: null'))
rendered.getByText('data: null')

fireEvent.click(rendered.getByRole('button', { name: /mutate/i }))

await vi.waitFor(() => rendered.getByText('data: data1'))
await vi.advanceTimersByTimeAsync(151)
rendered.getByText('data: data1')

expect(variables).toEqual([[], [1], []])
})
Expand Down
Loading