Skip to content

Conversation

@boschni
Copy link
Collaborator

@boschni boschni commented Aug 23, 2020

This MR addresses the following things:

  • Fixes bug where previously fetched pages were still remembered after setting new data with setQueryData.
  • Prevent unnecessary renders while performing infinite queries.
  • Reduce bundle size by around 10%.
  • Also update canFetchMore when setting data with setQueryData.

@vercel
Copy link

vercel bot commented Aug 23, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tannerlinsley/react-query/5c71tusxp
✅ Preview: https://react-query-git-fork-boschni-feature-optimize-infinite-queries.tannerlinsley.vercel.app

@boschni boschni force-pushed the feature/optimize-infinite-queries branch from 3952f1d to eee203f Compare August 23, 2020 11:01
@boschni boschni force-pushed the feature/optimize-infinite-queries branch from eee203f to 54656a9 Compare August 23, 2020 11:05
@boschni boschni changed the title refactor: reduce infinite query renders and bundle size WIP: refactor: reduce infinite query renders and bundle size Aug 24, 2020
@boschni boschni force-pushed the feature/optimize-infinite-queries branch from 54656a9 to 3205b30 Compare August 24, 2020 10:31
@vercel vercel bot temporarily deployed to Preview August 24, 2020 10:31 Inactive
@boschni boschni force-pushed the feature/optimize-infinite-queries branch from 3205b30 to 35cd891 Compare August 24, 2020 10:31
@boschni boschni changed the title WIP: refactor: reduce infinite query renders and bundle size refactor: reduce infinite query renders and bundle size Aug 24, 2020
@boschni boschni force-pushed the feature/optimize-infinite-queries branch from 35cd891 to bbc3e14 Compare August 24, 2020 16:09
@boschni boschni force-pushed the feature/optimize-infinite-queries branch from bbc3e14 to 4581871 Compare August 24, 2020 16:17
@tannerlinsley tannerlinsley merged commit 15f4186 into TanStack:master Aug 24, 2020
@tannerlinsley
Copy link
Member

🎉 This PR is included in version 2.11.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants