Skip to content

Conversation

@boschni
Copy link
Collaborator

@boschni boschni commented Aug 20, 2020

This MR includes the following changes:

  • Remove custom types.
  • Build generated types on release.
  • Remove type-only imports and exports from the declaration files to support TypeScript versions below 3.8.
  • Remove the type connection between the query key and the query function parameters because this does not match with the API. Parameters can be filtered with queryFnParamsFilter or added with for example the fetchMoreVariable variable. This also simplifies the typings for less experienced TS users.

@vercel
Copy link

vercel bot commented Aug 20, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tannerlinsley/react-query/ngnn9zpfn
✅ Preview: https://react-query-git-fork-boschni-feature-publish-typescript.tannerlinsley.vercel.app

@tannerlinsley
Copy link
Member

Just needs a rebase ;)

@tannerlinsley
Copy link
Member

🎉 This PR is included in version 2.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@robbtraister
Copy link

This appears to be a breaking change wrt typescript. In attempting to upgrade, I've noticed at least the following issues (with the latter being the more problematic of the two).

  • QueryOptions has been renamed QueryConfig
  • queryResult.isSuccess no longer implies that queryResult.data is defined

Should I open a new issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants